Re: [PATCH net-next-2.6] ifb: add performance flags to dev->features

[David Miller <davem@davemloft.net>]

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 20 Dec 2010 15:25:20 +0100

> Le lundi 20 décembre 2010 à 22:05 +0800, Changli Gao a écrit :
>> 2010/12/20 Jarek Poplawski <jarkao2@gmail.com>:
>> >
>> > IMHO it should, (probably even more, like loopback) but we should
>> > consider mirred can xmit to other than ifb too.
>> >
>> 
>> I also think so. And when making ifb a multiqueue NIC, I tried to add
>> these dev features to ifb. :)
>> 
> 
> This has litle to do with your multiqueue work,
> its more an effect of GRO being more and more deployed.
> 
> I dont see dev->features being changed in one of your previous patches.
> I did dummy case in commit 6d81f41c58c6
> 
> [PATCH net-next-2.6] ifb: add performance flags to dev->features
> 
> IFB can use the full set of features flags (NETIF_F_SG |
> NETIF_F_FRAGLIST | NETIF_F_TSO | NETIF_F_NO_CSUM | NETIF_F_HIGHDMA) to
> avoid unecessary split of some packets (GRO for example)
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>

Changli has suggested that these flags can also be set in
->vlan_features, please address that if you expect me to
apply the change.