From: David Miller <davem@davemloft.net>
To: paulus@samba.org
Cc: shemminger@vyatta.com, linux-ppp@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] ppp: allow disabling multilink protocol ID compression
Date: Tue, 28 Dec 2010 13:53:55 -0800 (PST) [thread overview]
Message-ID: <20101228.135355.115924746.davem@davemloft.net> (raw)
In-Reply-To: <20101221224400.GA17383@brick.ozlabs.ibm.com>
From: Paul Mackerras <paulus@samba.org>
Date: Wed, 22 Dec 2010 09:44:00 +1100
> On Mon, Dec 20, 2010 at 07:58:33PM -0800, Stephen Hemminger wrote:
>
>> Linux would not connect to other router running old version Cisco IOS (12.0).
>> This is most likely a bug in that version of IOS, since it is fixed
>> in later versions. As a workaround this patch allows a module parameter
>> to be set to disable compressing the protocol ID.
>>
>> See: https://bugzilla.vyatta.com/show_bug.cgi?id=3979
>>
>> RFC 1990 allows an implementation to formulate MP fragments as if protocol
>> compression had been negotiated. This allows us to always send compressed
>> protocol IDs. But some implementations don't accept MP fragments with
>> compressed protocol IDs. This parameter allows us to interoperate with
>> them. The default value of the configurable parameter is the same as the
>> current behavior: protocol compression is enabled. If protocol compression
>> is disabled we will not send compressed protocol IDs.
>>
>> This is based on an earlier patch by Bob Gilligan (using a sysctl).
>> Module parameter is writable to allow for enabling even if ppp
>> is already loaded for other uses.
>>
>> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
>
> Acked-by: Paul Mackerras <paulus@samba.org>
Applied, thanks.
prev parent reply other threads:[~2010-12-28 21:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-21 3:58 [PATCH] ppp: allow disabling multilink protocol ID compression Stephen Hemminger
2010-12-21 5:43 ` Eric Dumazet
2010-12-21 22:44 ` Paul Mackerras
2010-12-28 21:53 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101228.135355.115924746.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-ppp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).