From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: jengelh@medozas.de, netdev@vger.kernel.org
Subject: Re: [patch] net/unix: do not forget to autobind in standard case
Date: Tue, 28 Dec 2010 13:58:05 -0800 (PST) [thread overview]
Message-ID: <20101228.135805.260098055.davem@davemloft.net> (raw)
In-Reply-To: <1293554655.20573.5.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 28 Dec 2010 17:44:15 +0100
> Le samedi 25 décembre 2010 à 01:08 +0100, Jan Engelhardt a écrit :
>> parent 67514fc40bbec857018cbc689d440282b75551db (v2.6.37-rc1-229-g67514fc)
>> commit 973bdc63c6aba703dd7b62a6ec7ae4bab7847731
>> Author: Jan Engelhardt <jengelh@medozas.de>
>> Date: Sat Dec 25 00:50:59 2010 +0100
>>
>> net/unix: do not forget to autobind in standard case
>>
>> A program using recvmsg on an AF_LOCAL datagram socket does not
>> receive the peer's address when the remote has not issued a bind. This
>> makes it impossible to send messages back. (But the same _does_ work
>> in IP.) The cause for this is because autobinding was only done when
>> credential passing was requested.
>>
>
> It would be good you did some research and tell us why current code
> tests SOCK_PASSCRED
>
> There must be a reason this restrictive code is here, dont you think ?
I definitely think that test is intentional. I'm not applying this
without at least some basic research.
prev parent reply other threads:[~2010-12-28 21:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-25 0:08 [patch] net/unix: do not forget to autobind in standard case Jan Engelhardt
2010-12-28 16:44 ` Eric Dumazet
2010-12-28 21:58 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101228.135805.260098055.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jengelh@medozas.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).