From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Shawn Guo <shawn.guo@freescale.com>
Cc: Baruch Siach <baruch@tkos.co.il>,
davem@davemloft.net, gerg@snapgear.com, eric@eukrea.com,
bryan.wu@canonical.com, r64343@freescale.com,
B32542@freescale.com, lw@karo-electronics.de,
w.sang@pengutronix.de, s.hauer@pengutronix.de,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org
Subject: Re: [PATCH 03/10] net/fec: add mac field into platform data and consolidate fec_get_mac
Date: Wed, 29 Dec 2010 13:42:21 +0100 [thread overview]
Message-ID: <20101229124220.GD14221@pengutronix.de> (raw)
In-Reply-To: <20101229115808.GF19347@freescale.com>
Hello Shawn,
On Wed, Dec 29, 2010 at 07:58:09PM +0800, Shawn Guo wrote:
> On Wed, Dec 29, 2010 at 11:31:38AM +0100, Uwe Kleine-König wrote:
> > On Wed, Dec 29, 2010 at 06:05:21PM +0800, Shawn Guo wrote:
> > > On Wed, Dec 29, 2010 at 08:53:30AM +0200, Baruch Siach wrote:
> > > if (iap == fec_mac_default)
> > > dev->dev_addr[ETH_ALEN-1] = fec_mac_default[ETH_ALEN-1] + fep->pdev->id;
> > Can this overflow? (I didn't check the code, so my concern might be
> > completely stupid here.)
> No. dev->dev_addr points to netdev_hw_addr->addr, which is a 32 bytes array.
I didn't mean an out-of-bound access, but what is if
fec_mac_default[ETH_ALEN-1] is 0xff and you add 1? Does that result in
0x100 or 0? What if id is <0? For big ids you might even handle a
carry to indixes <ETH_ALEN-2.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2010-12-29 12:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1293548155-16328-1-git-send-email-shawn.guo@freescale.com>
[not found] ` <1293548155-16328-4-git-send-email-shawn.guo@freescale.com>
[not found] ` <20101229065329.GB31010@jasper.tkos.co.il>
[not found] ` <20101229103014.GD19347@freescale.com>
2010-12-29 10:37 ` [PATCH 03/10] net/fec: add mac field into platform data and consolidate fec_get_mac Uwe Kleine-König
2010-12-29 11:08 ` Shawn Guo
2010-12-29 11:10 ` Uwe Kleine-König
2010-12-29 12:00 ` Shawn Guo
[not found] ` <20101229100520.GB19347@freescale.com>
[not found] ` <20101229103138.GT14221@pengutronix.de>
2010-12-29 11:58 ` Shawn Guo
2010-12-29 12:42 ` Uwe Kleine-König [this message]
2010-12-30 2:12 ` Shawn Guo
2010-12-30 8:04 ` Uwe Kleine-König
2010-12-30 4:29 ` Shawn Guo
2010-12-30 5:29 ` Baruch Siach
2010-12-30 7:20 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101229124220.GD14221@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=B32542@freescale.com \
--cc=baruch@tkos.co.il \
--cc=bryan.wu@canonical.com \
--cc=davem@davemloft.net \
--cc=eric@eukrea.com \
--cc=gerg@snapgear.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lw@karo-electronics.de \
--cc=netdev@vger.kernel.org \
--cc=r64343@freescale.com \
--cc=s.hauer@pengutronix.de \
--cc=shawn.guo@freescale.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).