Re: [PATCH 03/10] net/fec: add mac field into platform data and consolidate fec_get_mac

[Shawn Guo <shawn.guo@freescale.com>]

On Thu, Dec 30, 2010 at 07:29:25AM +0200, Baruch Siach wrote:
> Hi Shawn,
> 
> On Thu, Dec 30, 2010 at 12:29:00PM +0800, Shawn Guo wrote:
> > On Wed, Dec 29, 2010 at 06:05:20PM +0800, Shawn Guo wrote:
> > > On Wed, Dec 29, 2010 at 08:53:30AM +0200, Baruch Siach wrote:
> > > > Please add netdev@vger.kernel.org to the Cc of all your fec driver 
> > > > patches.
> > > > 
> > > > On Tue, Dec 28, 2010 at 10:55:48PM +0800, Shawn Guo wrote:
> > > > > Add mac field into fec_platform_data and consolidate function
> > > > > fec_get_mac to get mac address in following order.
> > > > > 
> > > > >  1) kernel command line fec_mac=xx:xx:xx...
> > > > 
> > > > In the case of dual MAC that you later add support for, the address which one 
> > > > is being set? Is there a way to set both in kernel command line?
> > > > 
> > > The fec0 gets fec_mac and fec1 gets fec_mac + 1. The following code
> > > in function fec_get_mac takes care of it.
> > > 
> > > 	/* Adjust MAC if using default MAC address */
> > > 	if (iap == fec_mac_default)
> > > 		dev->dev_addr[ETH_ALEN-1] = fec_mac_default[ETH_ALEN-1] + fep->pdev->id;
> > > > Also, instead of inventing another kernel command line parameter, it is 
> > > > better IMO to use the module parameters mechanism. The greth NIC driver 
> > > > already uses this method for setting MAC address. Look for 'macaddr' in 
> > > > drivers/net/greth.c, and the explanation at the beginning of 
> > > > Documentation/kernel-parameters.txt.
> > > > 
> > > Sounds good. Thanks.
> > > 
> > I just thought this over again. Module parameter might not be
> > the best here. fec is usually used to mount nfs during boot,
> > which requires a built-in driver other than module.
> 
> See the explanation at the beginning of Documentation/kernel-parameters.txt.  
> You can give module parameters at the kernel command line.
> 
Ah, my dumb.

Just tested, and it works.  Thanks, Baruch.

-- 
Regards,
Shawn