From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Guo Subject: Re: [PATCH 03/10] net/fec: add mac field into platform data and consolidate fec_get_mac Date: Thu, 30 Dec 2010 15:20:21 +0800 Message-ID: <20101230072019.GA28246@freescale.com> References: <1293548155-16328-1-git-send-email-shawn.guo@freescale.com> <1293548155-16328-4-git-send-email-shawn.guo@freescale.com> <20101229065329.GB31010@jasper.tkos.co.il> <20101229100520.GB19347@freescale.com> <20101230042858.GA20651@freescale.com> <20101230052925.GA11160@jasper.tkos.co.il> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: , , , , , , , , , , , To: Baruch Siach Return-path: Received: from tx2ehsobe004.messaging.microsoft.com ([65.55.88.14]:18014 "EHLO TX2EHSOBE008.bigfish.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751453Ab0L3HSV (ORCPT ); Thu, 30 Dec 2010 02:18:21 -0500 Received: from mail90-tx2 (localhost.localdomain [127.0.0.1]) by mail90-tx2-R.bigfish.com (Postfix) with ESMTP id 664668D8411 for ; Thu, 30 Dec 2010 07:18:19 +0000 (UTC) Received: from TX2EHSMHS047.bigfish.com (unknown [10.9.14.244]) by mail90-tx2.bigfish.com (Postfix) with ESMTP id 1A678EB005B for ; Thu, 30 Dec 2010 07:18:19 +0000 (UTC) Received: from de01smr02.am.mot.com (de01smr02.freescale.net [10.208.0.151]) by az33egw01.freescale.net (8.14.3/8.14.3) with ESMTP id oBU7IAY3020013 for ; Thu, 30 Dec 2010 00:18:11 -0700 (MST) Received: from ubuntu.localdomain (ubuntu-010192242196.ap.freescale.net [10.192.242.196]) by de01smr02.am.mot.com (8.13.1/8.13.0) with ESMTP id oBU7bBkf015706 for ; Thu, 30 Dec 2010 01:37:12 -0600 (CST) Content-Disposition: inline In-Reply-To: <20101230052925.GA11160@jasper.tkos.co.il> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, Dec 30, 2010 at 07:29:25AM +0200, Baruch Siach wrote: > Hi Shawn, > > On Thu, Dec 30, 2010 at 12:29:00PM +0800, Shawn Guo wrote: > > On Wed, Dec 29, 2010 at 06:05:20PM +0800, Shawn Guo wrote: > > > On Wed, Dec 29, 2010 at 08:53:30AM +0200, Baruch Siach wrote: > > > > Please add netdev@vger.kernel.org to the Cc of all your fec driver > > > > patches. > > > > > > > > On Tue, Dec 28, 2010 at 10:55:48PM +0800, Shawn Guo wrote: > > > > > Add mac field into fec_platform_data and consolidate function > > > > > fec_get_mac to get mac address in following order. > > > > > > > > > > 1) kernel command line fec_mac=xx:xx:xx... > > > > > > > > In the case of dual MAC that you later add support for, the address which one > > > > is being set? Is there a way to set both in kernel command line? > > > > > > > The fec0 gets fec_mac and fec1 gets fec_mac + 1. The following code > > > in function fec_get_mac takes care of it. > > > > > > /* Adjust MAC if using default MAC address */ > > > if (iap == fec_mac_default) > > > dev->dev_addr[ETH_ALEN-1] = fec_mac_default[ETH_ALEN-1] + fep->pdev->id; > > > > Also, instead of inventing another kernel command line parameter, it is > > > > better IMO to use the module parameters mechanism. The greth NIC driver > > > > already uses this method for setting MAC address. Look for 'macaddr' in > > > > drivers/net/greth.c, and the explanation at the beginning of > > > > Documentation/kernel-parameters.txt. > > > > > > > Sounds good. Thanks. > > > > > I just thought this over again. Module parameter might not be > > the best here. fec is usually used to mount nfs during boot, > > which requires a built-in driver other than module. > > See the explanation at the beginning of Documentation/kernel-parameters.txt. > You can give module parameters at the kernel command line. > Ah, my dumb. Just tested, and it works. Thanks, Baruch. -- Regards, Shawn