From: David Miller <davem@davemloft.net>
To: amit.salecha@qlogic.com
Cc: netdev@vger.kernel.org, ameen.rahman@qlogic.com,
anirban.chakraborty@qlogic.com, sucheta.chakraborty@qlogic.com
Subject: Re: [PATCH NEXT 2/3] netxen: enable LRO based on NETIF_F_LRO
Date: Fri, 31 Dec 2010 10:58:12 -0800 (PST) [thread overview]
Message-ID: <20101231.105812.39181789.davem@davemloft.net> (raw)
In-Reply-To: <1293439423-25193-3-git-send-email-amit.salecha@qlogic.com>
From: Amit Kumar Salecha <amit.salecha@qlogic.com>
Date: Mon, 27 Dec 2010 00:43:42 -0800
> + if (!!data) {
This form of the test is not only unnecessary, it's ugly. Please just
test plain "data".
> + dev->features &= ~NETIF_F_LRO;
> + netxen_send_lro_cleanup(adapter);
> + dev_info(&adapter->pdev->dev,
> + "disabling LRO as rx_csum is off\n");
You should use netdev_info() and fix the tabbing here.
> + if (!adapter->rx_csum) {
> + dev_info(&adapter->pdev->dev, "rx csum is off, "
> + "cannot toggle LRO\n");
> + return -EINVAL;
> + }
Please use netdev_info().
next prev parent reply other threads:[~2010-12-31 18:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-27 8:43 [PATCH NEXT 0/3]netxen: updates Amit Kumar Salecha
2010-12-27 8:43 ` [PATCH NEXT 1/3] netxen: update module description Amit Kumar Salecha
2010-12-31 18:55 ` David Miller
2010-12-27 8:43 ` [PATCH NEXT 2/3] netxen: enable LRO based on NETIF_F_LRO Amit Kumar Salecha
2010-12-31 18:58 ` David Miller [this message]
2010-12-27 8:43 ` [PATCH NEXT 3/3] netxen: update driver version 4.0.75 Amit Kumar Salecha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101231.105812.39181789.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ameen.rahman@qlogic.com \
--cc=amit.salecha@qlogic.com \
--cc=anirban.chakraborty@qlogic.com \
--cc=netdev@vger.kernel.org \
--cc=sucheta.chakraborty@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).