* [patch] USB: cdc_ether: remove unneeded check
@ 2010-12-25 22:23 Dan Carpenter
2010-12-26 12:06 ` Oliver Neukum
2010-12-31 19:11 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2010-12-25 22:23 UTC (permalink / raw)
To: Oliver Neukum; +Cc: Greg Kroah-Hartman, linux-usb, netdev, kernel-janitors
We already verified that "dev->udev->actconfig->extralen" was non-zero
so "len" is non-zero here as well.
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
Compile tested.
diff --git a/drivers/net/usb/cdc_ether.c b/drivers/net/usb/cdc_ether.c
index b3fe0de..9a60e41 100644
--- a/drivers/net/usb/cdc_ether.c
+++ b/drivers/net/usb/cdc_ether.c
@@ -99,9 +99,7 @@ int usbnet_generic_cdc_bind(struct usbnet *dev, struct usb_interface *intf)
*/
buf = dev->udev->actconfig->extra;
len = dev->udev->actconfig->extralen;
- if (len)
- dev_dbg(&intf->dev,
- "CDC descriptors on config\n");
+ dev_dbg(&intf->dev, "CDC descriptors on config\n");
}
/* Maybe CDC descriptors are after the endpoint? This bug has
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [patch] USB: cdc_ether: remove unneeded check
2010-12-25 22:23 [patch] USB: cdc_ether: remove unneeded check Dan Carpenter
@ 2010-12-26 12:06 ` Oliver Neukum
2010-12-31 19:11 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Oliver Neukum @ 2010-12-26 12:06 UTC (permalink / raw)
To: Dan Carpenter
Cc: Oliver Neukum, Greg Kroah-Hartman, linux-usb, netdev,
kernel-janitors
Am Samstag, 25. Dezember 2010, 23:23:42 schrieb Dan Carpenter:
> We already verified that "dev->udev->actconfig->extralen" was non-zero
> so "len" is non-zero here as well.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Oliver Neukum <oneukum@suse.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] USB: cdc_ether: remove unneeded check
2010-12-25 22:23 [patch] USB: cdc_ether: remove unneeded check Dan Carpenter
2010-12-26 12:06 ` Oliver Neukum
@ 2010-12-31 19:11 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2010-12-31 19:11 UTC (permalink / raw)
To: error27; +Cc: oliver, gregkh, linux-usb, netdev, kernel-janitors
From: Dan Carpenter <error27@gmail.com>
Date: Sun, 26 Dec 2010 01:23:42 +0300
> We already verified that "dev->udev->actconfig->extralen" was non-zero
> so "len" is non-zero here as well.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-12-31 19:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-25 22:23 [patch] USB: cdc_ether: remove unneeded check Dan Carpenter
2010-12-26 12:06 ` Oliver Neukum
2010-12-31 19:11 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).