From: David Miller <davem@davemloft.net>
To: jj@chaosbits.net
Cc: joe@perches.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, zongxi@broadcom.com,
mchan@broadcom.com
Subject: Re: [PATCH v2] Broadcom CNIC core network driver: fix mem leak on allocation failures in cnic_alloc_uio_rings()
Date: Fri, 31 Dec 2010 11:20:25 -0800 (PST) [thread overview]
Message-ID: <20101231.112025.245393392.davem@davemloft.net> (raw)
In-Reply-To: <alpine.LNX.2.00.1012262154420.20797@swampdragon.chaosbits.net>
From: Jesper Juhl <jj@chaosbits.net>
Date: Sun, 26 Dec 2010 21:57:39 +0100 (CET)
> We are leaking memory in drivers/net/cnic.c::cnic_alloc_uio_rings() if
> either of the calls to dma_alloc_coherent() fail. This patch fixes it by
> freeing both the memory allocated with kzalloc() and memory allocated with
> previous calls to dma_alloc_coherent() when there's a failure.
>
> Thanks to Joe Perches <joe@perches.com> for suggesting a better
> implementation than my initial version.
>
>
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
...
> + err_dma:
> + dma_free_coherent(&udev->pdev->dev, udev->l2_ring_size,
> + udev->l2_ring, udev->l2_ring_map);
Space before tab in indentation, improperly positioned third argument
indentation.
I fixed all of this up, but please do not skimp on making sure these
details are taken care of when updating your patch in response to feedback.
Thanks.
next prev parent reply other threads:[~2010-12-31 19:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-26 20:30 [PATCH] Broadcom CNIC core network driver: fix mem leak on allocation failures in cnic_alloc_uio_rings() Jesper Juhl
2010-12-26 20:54 ` Joe Perches
2010-12-26 20:57 ` [PATCH v2] " Jesper Juhl
2010-12-27 3:57 ` Michael Chan
2010-12-31 19:20 ` David Miller [this message]
2011-01-02 18:54 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101231.112025.245393392.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jj@chaosbits.net \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=zongxi@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).