From: David Miller <davem@davemloft.net>
To: jcliburn@gmail.com
Cc: jussuf@linux.ee, kronos.it@gmail.com, chris.snook@gmail.com,
netdev@vger.kernel.org, Xiong.Huang@Atheros.com,
stable@kernel.org
Subject: Re: [PATCH] atl1: fix oops when changing tx/rx ring params
Date: Fri, 31 Dec 2010 12:08:31 -0800 (PST) [thread overview]
Message-ID: <20101231.120831.232749764.davem@davemloft.net> (raw)
In-Reply-To: <20101227095402.76f98027@osprey.hogchain.net>
From: "J. K. Cliburn" <jcliburn@gmail.com>
Date: Mon, 27 Dec 2010 09:54:02 -0600
> @@ -3544,11 +3546,20 @@ static int atl1_set_ringparam(struct net_device *netdev,
> adapter->rrd_ring = rrd_old;
> adapter->tpd_ring = tpd_old;
> adapter->ring_header = rhdr_old;
> + /*
> + * Save SMB and CMB, since atl1_free_ring_resources
> + * will clear them as a result of commit
> + * 3f5a2a713aad28480d86b0add00c68484b54febc
> + */
Please do not reference commit IDs in code comments.
Thank you.
next prev parent reply other threads:[~2010-12-31 20:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-27 15:54 [PATCH] atl1: fix oops when changing tx/rx ring params J. K. Cliburn
2010-12-31 20:08 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-01-01 15:02 J. K. Cliburn
2011-01-03 19:04 ` David Miller
2011-01-05 15:42 ` Luca Tettamanti
2011-01-05 15:45 ` Luca Tettamanti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101231.120831.232749764.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Xiong.Huang@Atheros.com \
--cc=chris.snook@gmail.com \
--cc=jcliburn@gmail.com \
--cc=jussuf@linux.ee \
--cc=kronos.it@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).