From: David Miller <davem@davemloft.net>
To: dsterba@suse.cz
Cc: mcarlson@broadcom.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, mchan@broadcom.com
Subject: Re: [PATCH v2] tg3: fix return value check in tg3_read_vpd()
Date: Fri, 31 Dec 2010 12:31:16 -0800 (PST) [thread overview]
Message-ID: <20101231.123116.229747013.davem@davemloft.net> (raw)
In-Reply-To: <1293630031-27372-1-git-send-email-dsterba@suse.cz>
From: David Sterba <dsterba@suse.cz>
Date: Wed, 29 Dec 2010 14:40:31 +0100
> Besides -ETIMEDOUT and -EINTR, pci_read_vpd may return other error
> values like -ENODEV or -EINVAL which are ignored due to the buggy
> check, but the data are not read from VPD anyway and this is checked
> subsequently with at most 3 needless loop iterations. This does not
> show up as a runtime bug.
>
> CC: Matt Carlson <mcarlson@broadcom.com>
> CC: Michael Chan <mchan@broadcom.com>
> Signed-off-by: David Sterba <dsterba@suse.cz>
Applied, thanks.
prev parent reply other threads:[~2010-12-31 20:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-27 17:31 [PATCH] tg3: fix return value check in tg3_read_vpd() David Sterba
2010-12-27 20:19 ` Dan Carpenter
2010-12-29 13:17 ` David Sterba
2010-12-29 13:40 ` [PATCH v2] " David Sterba
2010-12-31 20:31 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101231.123116.229747013.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dsterba@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).