From: Stephen Hemminger <shemminger@vyatta.com>
To: stefani@seibold.net
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH] UDPCP Communication Protocol
Date: Fri, 31 Dec 2010 09:46:34 -0800 [thread overview]
Message-ID: <20101231094634.5b96e0d1@s6510> (raw)
In-Reply-To: <1293787785-3834-1-git-send-email-stefani@seibold.net>
On Fri, 31 Dec 2010 10:29:45 +0100
stefani@seibold.net wrote:
> +struct __attribute__ ((packed)) udpcphdr {
> + struct udphdr udphdr;
> + __be32 chksum;
> + __be16 msginfo;
> + u8 fragamount;
> + u8 fragnum;
> + __be16 msgid;
> + __be16 length;
> +};
Adding (unnecessary) packed attribute will make access slow on
some architectures. For arch that can't do unaligned access, the
compiler ends up doing byte access for each element.
next prev parent reply other threads:[~2010-12-31 17:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-31 9:29 [PATCH] UDPCP Communication Protocol stefani
2010-12-31 10:00 ` Eric Dumazet
2010-12-31 10:22 ` Stefani Seibold
2010-12-31 10:41 ` Eric Dumazet
2010-12-31 11:23 ` Stefani Seibold
2010-12-31 11:54 ` Eric Dumazet
2011-01-01 21:40 ` Stefani Seibold
2011-01-10 22:28 ` Hagen Paul Pfeifer
2010-12-31 10:15 ` Eric Dumazet
2010-12-31 10:29 ` Stefani Seibold
2010-12-31 10:35 ` Eric Dumazet
2010-12-31 11:25 ` Eric Dumazet
2010-12-31 12:00 ` Eric Dumazet
2011-01-01 21:28 ` Stefani Seibold
2010-12-31 17:46 ` Stephen Hemminger [this message]
2010-12-31 17:46 ` Stephen Hemminger
2011-01-06 20:11 ` Pavel Machek
2011-01-06 20:17 ` David Miller
2011-01-10 22:53 ` Jesper Juhl
2011-01-11 0:49 ` Hagen Paul Pfeifer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101231094634.5b96e0d1@s6510 \
--to=shemminger@vyatta.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stefani@seibold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).