From: Stephen Hemminger <shemminger@vyatta.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>, David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org,
Stephen Hemminger <shemminger@linux-foundation.org>,
"Linux-pm mailing list" <linux-pm@lists.linux-foundation.org>
Subject: Re: [PATCH] sky2: Do not use legacy PCI power management
Date: Fri, 31 Dec 2010 10:15:21 -0800 [thread overview]
Message-ID: <20101231101521.598d41c6@s6510> (raw)
In-Reply-To: <201012261944.32517.rjw@sisk.pl>
On Sun, 26 Dec 2010 19:44:32 +0100
"Rafael J. Wysocki" <rjw@sisk.pl> wrote:
> From: Rafael J. Wysocki <rjw@sisk.pl>
>
> The sky2 driver uses the legacy PCI power management, so it has to do
> some PCI-specific things in its ->suspend() and ->resume() callbacks,
> which isn't necessary and should better be done by the PCI
> sybsystem-level power management code. Moreover, it uses
> device_set_wakeup_enable() incorrectly (that function should be
> used when the WoL setting is changed rather than during suspend).
>
> Convert sky2 to the new PCI power management framework and make it
> let the PCI subsystem take care of all the PCI-specific aspects of
> device handling during system power transitions.
>
> Tested on a desktop machine with a Marvell 88E8056 PCI-E adapter.
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Tested on 88E8055 (laptop), my desktop machines have video issues and
won't suspend/resume.
Acked-by: Stephen Hemminger <shemminger@vyatta.com>
next prev parent reply other threads:[~2010-12-31 18:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-26 18:44 [PATCH] sky2: Do not use legacy PCI power management Rafael J. Wysocki
2010-12-30 18:52 ` [PATCH] skge: " Stephen Hemminger
2010-12-30 22:50 ` Rafael J. Wysocki
2010-12-31 20:50 ` David Miller
2010-12-31 18:15 ` Stephen Hemminger [this message]
2010-12-31 19:14 ` [PATCH] sky2: " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101231101521.598d41c6@s6510 \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=linux-pm@lists.linux-foundation.org \
--cc=netdev@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).