From: David Miller <davem@davemloft.net>
To: tomas.winkler@intel.com
Cc: netdev@vger.kernel.org, johannes@sipsolutions.net, shemminger@vyatta.com
Subject: Re: [PATCH V4] bridge: fix br_multicast_ipv6_rcv for paged skbs
Date: Mon, 03 Jan 2011 11:29:26 -0800 (PST) [thread overview]
Message-ID: <20110103.112926.48505128.davem@davemloft.net> (raw)
In-Reply-To: <1294051080-29492-1-git-send-email-tomas.winkler@intel.com>
From: Tomas Winkler <tomas.winkler@intel.com>
Date: Mon, 3 Jan 2011 12:37:59 +0200
> use pskb_may_pull to access ipv6 header correctly for paged skbs
> It was omitted in the bridge code leading to crash in blind
> __skb_pull
>
> since the skb is cloned undonditionally we also simplify the
> the exit path
>
> this fixes bug https://bugzilla.kernel.org/show_bug.cgi?id=25202
...
> Cc: David Miller <davem@davemloft.net>
> Cc: Johannes Berg <johannes@sipsolutions.net>
> Cc: Stephen Hemminger <shemminger@vyatta.com>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Looks good, applied thanks Tomas.
There are several simplifications we can make in the net-next-2.6
tree.
Most of this code just wants the query type and then optionally
the ipv6 address the operation applies to. For such simple value
fetching, skb_header_pointer() is probably ideal compared to
all of this pskb_may_pull() business.
prev parent reply other threads:[~2011-01-03 19:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-03 10:37 [PATCH V4] bridge: fix br_multicast_ipv6_rcv for paged skbs Tomas Winkler
2011-01-03 10:38 ` Tomas Winkler
2011-01-03 19:29 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110103.112926.48505128.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).