From: David Miller <davem@davemloft.net>
To: nicolas.2p.debian@free.fr
Cc: bonding-devel@lists.sourceforge.net, netdev@vger.kernel.org,
fubar@us.ibm.com
Subject: Re: [PATCH net-next-2.6] bonding: remove meaningless /sys/module/bonding/parameters entries.
Date: Mon, 03 Jan 2011 11:32:12 -0800 (PST) [thread overview]
Message-ID: <20110103.113212.260088613.davem@davemloft.net> (raw)
In-Reply-To: <1293978915-29674-1-git-send-email-nicolas.2p.debian@free.fr>
From: Nicolas de Pesloüan <nicolas.2p.debian@free.fr>
Date: Sun, 2 Jan 2011 15:35:15 +0100
> Only two bonding parameters are exposed in /sys/module/bonding:
>
> num_grat_arp
> num_unsol_na
>
> Those values are not module global, but per device.
>
> The per device values are available in /sys/class/net/<device>/bonding.
>
> The values exposed in /sys/module/bonding are those given at module load time
> and only used as default values when creating a device. They are read-only and
> cannot change in any way.
>
> As such, they are mostly meaningless.
First, you forgot to provide a proper "Signed-off-by: " line in your
patch submission, please read Documentation/SubmittingPatches
Secondly, you can't remove these, people might be using them. It
could be useful, for example, to debug problems with passing module
parameters in. This is the one way to find out what actually got
passed to the module when it loaded.
Therefore I'm not applying this patch, sorry.
next prev parent reply other threads:[~2011-01-03 19:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-02 14:35 [PATCH net-next-2.6] bonding: remove meaningless /sys/module/bonding/parameters entries Nicolas de Pesloüan
2011-01-03 19:32 ` David Miller [this message]
2011-01-03 19:59 ` [Bonding-devel] " Nicolas de Pesloüan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110103.113212.260088613.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bonding-devel@lists.sourceforge.net \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.2p.debian@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).