From: David Miller <davem@davemloft.net>
To: jarkao2@gmail.com
Cc: eric.dumazet@gmail.com, xiaosuo@gmail.com, pstaszewski@itcare.pl,
netdev@vger.kernel.org
Subject: Re: [PATCH v2 net-next-2.6] ifb: add performance flags
Date: Mon, 03 Jan 2011 11:40:33 -0800 (PST) [thread overview]
Message-ID: <20110103.114033.28807428.davem@davemloft.net> (raw)
In-Reply-To: <20110103193703.GA1977@del.dom.local>
From: Jarek Poplawski <jarkao2@gmail.com>
Date: Mon, 3 Jan 2011 20:37:03 +0100
> On Sun, Jan 02, 2011 at 09:24:36PM +0100, Eric Dumazet wrote:
>> Le mercredi 29 décembre 2010 ?? 00:07 +0100, Jarek Poplawski a écrit :
>>
>> > Ingress is before vlans handler so these features and the
>> > NETIF_F_HW_VLAN_TX flag seem useful for ifb considering
>> > dev_hard_start_xmit() checks.
>>
>> OK, here is v2 of the patch then, thanks everybody.
>>
>>
>> [PATCH v2 net-next-2.6] ifb: add performance flags
>>
>> IFB can use the full set of features flags (NETIF_F_SG |
>> NETIF_F_FRAGLIST | NETIF_F_TSO | NETIF_F_NO_CSUM | NETIF_F_HIGHDMA) to
>> avoid unnecessary split of some packets (GRO for example)
>>
>> Changli suggested to also set vlan_features,
>
> He also suggested more GSO flags of which especially NETIF_F_TSO6
> seems interesting (wrt GRO)?
I think at least TSO6 would very much be appropriate here.
next prev parent reply other threads:[~2011-01-03 19:40 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-19 11:35 Kernel panic eth2 mirred redirect to ifb0 Paweł Staszewski
2010-12-19 11:39 ` Paweł Staszewski
2010-12-19 15:43 ` Eric Dumazet
2010-12-19 16:09 ` Paweł Staszewski
2010-12-19 16:22 ` Changli Gao
2010-12-19 20:34 ` Paweł Staszewski
2010-12-19 22:15 ` Jarek Poplawski
2010-12-19 22:21 ` Jarek Poplawski
2010-12-19 22:26 ` Jarek Poplawski
2010-12-20 8:01 ` Paweł Staszewski
2010-12-20 8:06 ` Eric Dumazet
2010-12-20 9:13 ` Paweł Staszewski
2010-12-20 8:56 ` Changli Gao
2010-12-20 9:08 ` Eric Dumazet
2010-12-20 9:11 ` Changli Gao
2010-12-20 9:21 ` Eric Dumazet
2010-12-20 10:32 ` Jarek Poplawski
2010-12-20 10:41 ` Eric Dumazet
2010-12-20 11:11 ` Jarek Poplawski
2010-12-20 11:58 ` Jarek Poplawski
2010-12-20 12:07 ` Paweł Staszewski
2010-12-20 12:22 ` Jarek Poplawski
2010-12-20 12:45 ` Eric Dumazet
2010-12-20 12:54 ` Eric Dumazet
2010-12-20 13:02 ` Jarek Poplawski
2010-12-20 14:05 ` Changli Gao
2010-12-20 14:25 ` [PATCH net-next-2.6] ifb: add performance flags to dev->features Eric Dumazet
2010-12-20 14:43 ` Changli Gao
2010-12-28 21:50 ` David Miller
2010-12-28 22:36 ` Eric Dumazet
2010-12-28 23:07 ` Jarek Poplawski
2011-01-02 20:24 ` [PATCH v2 net-next-2.6] ifb: add performance flags Eric Dumazet
2011-01-03 19:37 ` Jarek Poplawski
2011-01-03 19:40 ` David Miller [this message]
2011-01-03 20:35 ` Eric Dumazet
2011-01-03 20:40 ` David Miller
2010-12-20 12:30 ` Kernel panic eth2 mirred redirect to ifb0 Changli Gao
2010-12-20 13:37 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110103.114033.28807428.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jarkao2@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pstaszewski@itcare.pl \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).