From: David Miller <davem@davemloft.net>
To: sedat.dilek@googlemail.com
Cc: samuel@sortiz.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, sedat.dilek@gmail.com
Subject: Re: [PATCH] smsc-ircc2: Fix section mismatch derived from smsc_ircc_pnp_driver variable
Date: Mon, 03 Jan 2011 11:53:19 -0800 (PST) [thread overview]
Message-ID: <20110103.115319.245401044.davem@davemloft.net> (raw)
In-Reply-To: <1294021724-30337-1-git-send-email-sedat.dilek@gmail.com>
From: Sedat Dilek <sedat.dilek@googlemail.com>
Date: Mon, 3 Jan 2011 03:28:44 +0100
>>From my build.log:
>
> drivers/net/irda/smsc-ircc2.o(.data+0x18): Section mismatch in reference from the variable smsc_ircc_pnp_driver to the function .init.text:smsc_ircc_pnp_probe()
> The variable smsc_ircc_pnp_driver references
> the function __init smsc_ircc_pnp_probe()
> If the reference is valid then annotate the
> variable with __init* or __refdata (see linux/init.h) or name the variable:
> *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console,
>
> This patch fixes the warning.
>
> Tested with linux-next (next-20101231)
>
> Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
Just like your other patch, this fix is not correct.
Mark smsc_ircc_pbp_probe() as __devinit instead of __init to fix
this bug.
next prev parent reply other threads:[~2011-01-03 19:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-03 2:28 [PATCH] smsc-ircc2: Fix section mismatch derived from smsc_ircc_pnp_driver variable Sedat Dilek
2011-01-03 19:53 ` David Miller [this message]
2011-01-03 21:16 ` Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110103.115319.245401044.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=samuel@sortiz.org \
--cc=sedat.dilek@gmail.com \
--cc=sedat.dilek@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).