* [PATCH] depca: Fix section mismatch derived from depca_isa_driver variable
@ 2011-01-03 2:33 Sedat Dilek
2011-01-03 19:53 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Sedat Dilek @ 2011-01-03 2:33 UTC (permalink / raw)
To: netdev, linux-kernel; +Cc: Sedat Dilek
>From my build.log:
WARNING: drivers/net/depca.o(.data+0x0): Section mismatch in reference from the variable depca_isa_driver to the function .init.text:depca_isa_probe()
The variable depca_isa_driver references
the function __init depca_isa_probe()
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console,
This patch fixes the warning.
Tested with linux-next (next-20101231)
Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
---
drivers/net/depca.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/depca.c b/drivers/net/depca.c
index 91b3846..dfaf746 100644
--- a/drivers/net/depca.c
+++ b/drivers/net/depca.c
@@ -405,7 +405,7 @@ static int __devexit depca_isa_remove(struct platform_device *pdev)
return depca_device_remove(&pdev->dev);
}
-static struct platform_driver depca_isa_driver = {
+static struct platform_driver depca_isa_driver __refdata = {
.probe = depca_isa_probe,
.remove = __devexit_p(depca_isa_remove),
.driver = {
--
1.7.4.rc0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] depca: Fix section mismatch derived from depca_isa_driver variable
2011-01-03 2:33 [PATCH] depca: Fix section mismatch derived from depca_isa_driver variable Sedat Dilek
@ 2011-01-03 19:53 ` David Miller
2011-01-03 21:23 ` Sedat Dilek
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2011-01-03 19:53 UTC (permalink / raw)
To: sedat.dilek; +Cc: netdev, linux-kernel, sedat.dilek
From: Sedat Dilek <sedat.dilek@googlemail.com>
Date: Mon, 3 Jan 2011 03:33:07 +0100
>>From my build.log:
>
> WARNING: drivers/net/depca.o(.data+0x0): Section mismatch in reference from the variable depca_isa_driver to the function .init.text:depca_isa_probe()
> The variable depca_isa_driver references
> the function __init depca_isa_probe()
> If the reference is valid then annotate the
> variable with __init* or __refdata (see linux/init.h) or name the variable:
> *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console,
>
> This patch fixes the warning.
>
> Tested with linux-next (next-20101231)
>
> Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
Again, mark depca_isa_probe() as __devinit to fix this bug.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] depca: Fix section mismatch derived from depca_isa_driver variable
2011-01-03 19:53 ` David Miller
@ 2011-01-03 21:23 ` Sedat Dilek
0 siblings, 0 replies; 3+ messages in thread
From: Sedat Dilek @ 2011-01-03 21:23 UTC (permalink / raw)
To: David Miller; +Cc: netdev, linux-kernel
On Mon, Jan 3, 2011 at 8:53 PM, David Miller <davem@davemloft.net> wrote:
> From: Sedat Dilek <sedat.dilek@googlemail.com>
> Date: Mon, 3 Jan 2011 03:33:07 +0100
>
>>>From my build.log:
>>
>> WARNING: drivers/net/depca.o(.data+0x0): Section mismatch in reference from the variable depca_isa_driver to the function .init.text:depca_isa_probe()
>> The variable depca_isa_driver references
>> the function __init depca_isa_probe()
>> If the reference is valid then annotate the
>> variable with __init* or __refdata (see linux/init.h) or name the variable:
>> *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console,
>>
>> This patch fixes the warning.
>>
>> Tested with linux-next (next-20101231)
>>
>> Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
>
> Again, mark depca_isa_probe() as __devinit to fix this bug.
>
Thanks for the pointer, I have sent a new fixed version.
- Sedat -
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-01-03 21:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-03 2:33 [PATCH] depca: Fix section mismatch derived from depca_isa_driver variable Sedat Dilek
2011-01-03 19:53 ` David Miller
2011-01-03 21:23 ` Sedat Dilek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).