* [PATCH, second try] Typo in comments in include/linux/igmp.h
@ 2011-01-03 16:03 François-Xavier Le Bail
2011-01-03 20:11 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: François-Xavier Le Bail @ 2011-01-03 16:03 UTC (permalink / raw)
To: netdev
[-- Attachment #1: Type: text/plain, Size: 922 bytes --]
[Second try, patch invalid, sorry]
Hello,
There is a typo in comments in include/linux/igmp.h:
83 #define IGMP_HOST_MEMBERSHIP_QUERY 0x11 /* From RFC1112 */
84 #define IGMP_HOST_MEMBERSHIP_REPORT 0x12 /* Ditto */
85 #define IGMP_DVMRP 0x13 /* DVMRP routing */
86 #define IGMP_PIM 0x14 /* PIM routing */
87 #define IGMP_TRACE 0x15
88 #define IGMPV2_HOST_MEMBERSHIP_REPORT 0x16 /* V2 version of 0x11 */
89 #define IGMP_HOST_LEAVE_MESSAGE 0x17
90 #define IGMPV3_HOST_MEMBERSHIP_REPORT 0x22 /* V3 version of 0x11 */
The line 88 and 90 are about REPORT messages.
The IGMP_HOST_MEMBERSHIP_REPORT value is 0x12.
So the comment on line 88 must be /* V2 version of 0x12 */,
and the comment on line 90 must be /* V3 version of 0x12 */.
Here is a patch.
Thank you,
Francois-Xavier Le Bail
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: igmp_h.diff --]
[-- Type: text/x-diff; name="igmp_h.diff", Size: 693 bytes --]
diff -ru a/include/linux/igmp.h b/include/linux/igmp.h
--- a/include/linux/igmp.h 2010-08-27 01:47:12.000000000 +0200
+++ b/include/linux/igmp.h 2010-12-15 09:50:47.808363144 +0100
@@ -85,9 +85,9 @@
#define IGMP_DVMRP 0x13 /* DVMRP routing */
#define IGMP_PIM 0x14 /* PIM routing */
#define IGMP_TRACE 0x15
-#define IGMPV2_HOST_MEMBERSHIP_REPORT 0x16 /* V2 version of 0x11 */
+#define IGMPV2_HOST_MEMBERSHIP_REPORT 0x16 /* V2 version of 0x12 */
#define IGMP_HOST_LEAVE_MESSAGE 0x17
-#define IGMPV3_HOST_MEMBERSHIP_REPORT 0x22 /* V3 version of 0x11 */
+#define IGMPV3_HOST_MEMBERSHIP_REPORT 0x22 /* V3 version of 0x12 */
#define IGMP_MTRACE_RESP 0x1e
#define IGMP_MTRACE 0x1f
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH, second try] Typo in comments in include/linux/igmp.h
2011-01-03 16:03 [PATCH, second try] Typo in comments in include/linux/igmp.h François-Xavier Le Bail
@ 2011-01-03 20:11 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2011-01-03 20:11 UTC (permalink / raw)
To: fx.lebail; +Cc: netdev
From: François-Xavier Le Bail <fx.lebail@yahoo.com>
Date: Mon, 3 Jan 2011 08:03:36 -0800 (PST)
> [Second try, patch invalid, sorry]
You need to provide a proper "Signed-off-by: " tag in your commit
message.
Please read Documentation/SubmittingPatches and resubmit your patch.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-01-03 20:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-03 16:03 [PATCH, second try] Typo in comments in include/linux/igmp.h François-Xavier Le Bail
2011-01-03 20:11 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).