From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kurt Van Dijck Subject: Re: [PATCH net-next-2.6 1/2] can: add driver for Softing card Date: Mon, 3 Jan 2011 17:28:26 +0100 Message-ID: <20110103162826.GC320@e-circ.dyndns.org> References: <20101223093627.GA325@e-circ.dyndns.org> <20101223094302.GB325@e-circ.dyndns.org> <4D135BC3.6070707@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Marc Kleine-Budde Return-path: Content-Disposition: inline In-Reply-To: <4D135BC3.6070707-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org Errors-To: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org List-Id: netdev.vger.kernel.org On Thu, Dec 23, 2010 at 03:25:07PM +0100, Marc Kleine-Budde wrote: > > Another option is to write a threaded interrupt handler. It seems a threaded irq is the way to go. During the implementation, a locking issue came up. Am I right that within a threaded irq handler, I should use spin_lock_bh() to prevent the ndo_start_xmit() to be called (ie. prevent the softirq). > Kurt