From: David Miller <davem@davemloft.net>
To: fx.lebail@orange.fr
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v2] net: typos in comments in include/linux/igmp.h
Date: Tue, 04 Jan 2011 11:30:01 -0800 (PST) [thread overview]
Message-ID: <20110104.113001.28819146.davem@davemloft.net> (raw)
In-Reply-To: <4D23709C.1040408@orange.fr>
From: Francois-Xavier Le Bail <fx.lebail@orange.fr>
Date: Tue, 04 Jan 2011 20:10:20 +0100
> There are typos in comments in include/linux/igmp.h:
>
> 83 #define IGMP_HOST_MEMBERSHIP_QUERY 0x11 /* From RFC1112 */
> 84 #define IGMP_HOST_MEMBERSHIP_REPORT 0x12 /* Ditto */
> [snip]
> 88 #define IGMPV2_HOST_MEMBERSHIP_REPORT 0x16 /* V2 version of 0x11 */
> 89 #define IGMP_HOST_LEAVE_MESSAGE 0x17
> 90 #define IGMPV3_HOST_MEMBERSHIP_REPORT 0x22 /* V3 version of 0x11 */
>
> The line 88 and 90 are about REPORT messages.
> The IGMP_HOST_MEMBERSHIP_REPORT (IGMP V1) value is 0x12.
> So the comment on line 88 must be /* V2 version of 0x12 */,
> and the comment on line 90 must be /* V3 version of 0x12 */.
>
> Signed-off-by: Francois-Xavier Le Bail <fx.lebail@orange.fr>
Applied, thanks.
prev parent reply other threads:[~2011-01-04 19:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-04 19:10 [PATCH v2] net: typos in comments in include/linux/igmp.h Francois-Xavier Le Bail
2011-01-04 19:30 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110104.113001.28819146.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fx.lebail@orange.fr \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).