* [PATCH v2] net: typos in comments in include/linux/igmp.h
@ 2011-01-04 19:10 Francois-Xavier Le Bail
2011-01-04 19:30 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Francois-Xavier Le Bail @ 2011-01-04 19:10 UTC (permalink / raw)
To: netdev
There are typos in comments in include/linux/igmp.h:
83 #define IGMP_HOST_MEMBERSHIP_QUERY 0x11 /* From RFC1112 */
84 #define IGMP_HOST_MEMBERSHIP_REPORT 0x12 /* Ditto */
[snip]
88 #define IGMPV2_HOST_MEMBERSHIP_REPORT 0x16 /* V2 version of 0x11 */
89 #define IGMP_HOST_LEAVE_MESSAGE 0x17
90 #define IGMPV3_HOST_MEMBERSHIP_REPORT 0x22 /* V3 version of 0x11 */
The line 88 and 90 are about REPORT messages.
The IGMP_HOST_MEMBERSHIP_REPORT (IGMP V1) value is 0x12.
So the comment on line 88 must be /* V2 version of 0x12 */,
and the comment on line 90 must be /* V3 version of 0x12 */.
Signed-off-by: Francois-Xavier Le Bail <fx.lebail@orange.fr>
---
diff -ru a/include/linux/igmp.h b/include/linux/igmp.h
--- a/include/linux/igmp.h 2010-08-27 01:47:12.000000000 +0200
+++ b/include/linux/igmp.h 2010-12-15 09:50:47.808363144 +0100
@@ -85,9 +85,9 @@
#define IGMP_DVMRP 0x13 /* DVMRP routing */
#define IGMP_PIM 0x14 /* PIM routing */
#define IGMP_TRACE 0x15
-#define IGMPV2_HOST_MEMBERSHIP_REPORT 0x16 /* V2 version of 0x11 */
+#define IGMPV2_HOST_MEMBERSHIP_REPORT 0x16 /* V2 version of 0x12 */
#define IGMP_HOST_LEAVE_MESSAGE 0x17
-#define IGMPV3_HOST_MEMBERSHIP_REPORT 0x22 /* V3 version of 0x11 */
+#define IGMPV3_HOST_MEMBERSHIP_REPORT 0x22 /* V3 version of 0x12 */
#define IGMP_MTRACE_RESP 0x1e
#define IGMP_MTRACE 0x1f
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] net: typos in comments in include/linux/igmp.h
2011-01-04 19:10 [PATCH v2] net: typos in comments in include/linux/igmp.h Francois-Xavier Le Bail
@ 2011-01-04 19:30 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2011-01-04 19:30 UTC (permalink / raw)
To: fx.lebail; +Cc: netdev
From: Francois-Xavier Le Bail <fx.lebail@orange.fr>
Date: Tue, 04 Jan 2011 20:10:20 +0100
> There are typos in comments in include/linux/igmp.h:
>
> 83 #define IGMP_HOST_MEMBERSHIP_QUERY 0x11 /* From RFC1112 */
> 84 #define IGMP_HOST_MEMBERSHIP_REPORT 0x12 /* Ditto */
> [snip]
> 88 #define IGMPV2_HOST_MEMBERSHIP_REPORT 0x16 /* V2 version of 0x11 */
> 89 #define IGMP_HOST_LEAVE_MESSAGE 0x17
> 90 #define IGMPV3_HOST_MEMBERSHIP_REPORT 0x22 /* V3 version of 0x11 */
>
> The line 88 and 90 are about REPORT messages.
> The IGMP_HOST_MEMBERSHIP_REPORT (IGMP V1) value is 0x12.
> So the comment on line 88 must be /* V2 version of 0x12 */,
> and the comment on line 90 must be /* V3 version of 0x12 */.
>
> Signed-off-by: Francois-Xavier Le Bail <fx.lebail@orange.fr>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-01-04 19:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-04 19:10 [PATCH v2] net: typos in comments in include/linux/igmp.h Francois-Xavier Le Bail
2011-01-04 19:30 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).