From: David Miller <davem@davemloft.net>
To: hagen@jauu.net
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org, fw@strlen.de,
kaber@trash.net, shemminger@vyatta.com, jarkao2@gmail.com
Subject: Re: [PATCH] net_sched: pfifo_head_drop problem
Date: Wed, 05 Jan 2011 13:39:40 -0800 (PST) [thread overview]
Message-ID: <20110105.133940.179942285.davem@davemloft.net> (raw)
In-Reply-To: <20110105205217.GC10322@nuttenaction>
From: Hagen Paul Pfeifer <hagen@jauu.net>
Date: Wed, 5 Jan 2011 21:52:17 +0100
> * Eric Dumazet | 2011-01-05 21:35:02 [+0100]:
>
>>My mid term suggestion would be to change things so that
>>sch->bstats.bytes and sch->bstats.packets are incremented in dequeue()
>>only, not at enqueue() time. We also could add drop_bytes/drop_packets
>>and provide estimations of drop rates.
>>
>>It would be more sensible anyway for very low speeds, and big bursts.
>>Right now, if we drop packets, they still are accounted in byte/packets
>>abolute counters and rate estimators.
>>
>>Before this mid term change, this patch makes pfifo_head_drop behavior
>>similar to other qdiscs in case of drops :
>>Dont decrement sch->bstats.bytes and sch->bstats.packets
>
> Thanks Stephen and Erik for spotting this bug!
>
>>Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
>
> Acked-by: Hagen Paul Pfeifer <hagen@jauu.net>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2011-01-05 21:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-05 17:00 [BUG] net_sched: pfifo_head_drop problem Eric Dumazet
2011-01-05 17:15 ` Stephen Hemminger
2011-01-05 20:35 ` [PATCH] " Eric Dumazet
2011-01-05 20:52 ` Hagen Paul Pfeifer
2011-01-05 21:39 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110105.133940.179942285.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=fw@strlen.de \
--cc=hagen@jauu.net \
--cc=jarkao2@gmail.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).