netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@vyatta.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] ipv4: IP defragmentation must be ECN aware
Date: Wed, 5 Jan 2011 09:13:40 -0800	[thread overview]
Message-ID: <20110105091340.3f8833ef@nehalam> (raw)
In-Reply-To: <1294235942.2775.191.camel@edumazet-laptop>

On Wed, 05 Jan 2011 14:59:02 +0100
Eric Dumazet <eric.dumazet@gmail.com> wrote:

> +
> +static inline int ip4_frag_ecn(int tos)

Since tos is only a byte, this should be:

static inline u8 ip4_frag_ecn(u8 tos)


-- 

  reply	other threads:[~2011-01-05 17:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-05  0:13 [RFC] ECN and IP defragmentation Eric Dumazet
2011-01-05  2:53 ` David Miller
2011-01-05 13:59 ` [PATCH] ipv4: IP defragmentation must be ECN aware Eric Dumazet
2011-01-05 17:13   ` Stephen Hemminger [this message]
2011-01-05 17:41     ` Eric Dumazet
2011-01-05 17:48       ` Stephen Hemminger
2011-01-05 17:52         ` Eric Dumazet
2011-01-06 19:21           ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110105091340.3f8833ef@nehalam \
    --to=shemminger@vyatta.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).