netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [RFC PATCH net-next] if_ether.h: Add #define ETH_P_LARQ for HPNA/LARQ
@ 2010-12-14  0:47 Joe Perches
  2010-12-14  1:49 ` Henry Ptasinski
  0 siblings, 1 reply; 6+ messages in thread
From: Joe Perches @ 2010-12-14  0:47 UTC (permalink / raw)
  To: netdev; +Cc: Brett Rudley, Henry Ptasinski, Dowan Kim

LARQ seems to be used by Broadcom's staging driver.
Might as well add a #define for it to the normal location.

Signed-off-by: Joe Perches <joe@perches.com>
---
 include/linux/if_ether.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/include/linux/if_ether.h b/include/linux/if_ether.h
index f9c3df0..b257e99 100644
--- a/include/linux/if_ether.h
+++ b/include/linux/if_ether.h
@@ -71,6 +71,8 @@
 #define ETH_P_PPP_SES	0x8864		/* PPPoE session messages	*/
 #define ETH_P_MPLS_UC	0x8847		/* MPLS Unicast traffic		*/
 #define ETH_P_MPLS_MC	0x8848		/* MPLS Multicast traffic	*/
+#define ETH_P_LARQ	0x886c		/* HPNA / Broadcom
+					 * Limited Automatic Repeat reQuest */
 #define ETH_P_ATMMPOA	0x884c		/* MultiProtocol Over ATM	*/
 #define ETH_P_ATMFATE	0x8884		/* Frame-based ATM Transport
 					 * over Ethernet



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [RFC PATCH net-next] if_ether.h: Add #define ETH_P_LARQ for HPNA/LARQ
  2010-12-14  0:47 [RFC PATCH net-next] if_ether.h: Add #define ETH_P_LARQ for HPNA/LARQ Joe Perches
@ 2010-12-14  1:49 ` Henry Ptasinski
  2010-12-14  3:53   ` Joe Perches
  0 siblings, 1 reply; 6+ messages in thread
From: Henry Ptasinski @ 2010-12-14  1:49 UTC (permalink / raw)
  To: Joe Perches
  Cc: netdev, Brett Rudley, Dowan Kim, Henry Ptasinski, arend, rvossen

On Mon, Dec 13, 2010 at 04:47:47PM -0800, Joe Perches wrote:
> LARQ seems to be used by Broadcom's staging driver.
> Might as well add a #define for it to the normal location.
> 
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>  include/linux/if_ether.h |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/if_ether.h b/include/linux/if_ether.h
> index f9c3df0..b257e99 100644
> --- a/include/linux/if_ether.h
> +++ b/include/linux/if_ether.h
> @@ -71,6 +71,8 @@
>  #define ETH_P_PPP_SES	0x8864		/* PPPoE session messages	*/
>  #define ETH_P_MPLS_UC	0x8847		/* MPLS Unicast traffic		*/
>  #define ETH_P_MPLS_MC	0x8848		/* MPLS Multicast traffic	*/
> +#define ETH_P_LARQ	0x886c		/* HPNA / Broadcom
> +					 * Limited Automatic Repeat reQuest */


That should be ETH_P_BRCM (or ETH_P_EPIGRAM).  HPNA/ILCP used a range of
subtypes for LARQ and other HPNA protocols.  The brcmfmac driver uses a
different subypte for encapsulating some event signals between the device and
the host, but doesn't implement any of the HPNA protocols.

- Henry



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [RFC PATCH net-next] if_ether.h: Add #define ETH_P_LARQ for HPNA/LARQ
  2010-12-14  1:49 ` Henry Ptasinski
@ 2010-12-14  3:53   ` Joe Perches
  2010-12-15 21:22     ` Henry Ptasinski
  2011-01-05  2:07     ` [PATCH] include/linux/if_ether.h: Add #define ETH_P_LINK_CTL for HPNA and wlan local tunnel Henry Ptasinski
  0 siblings, 2 replies; 6+ messages in thread
From: Joe Perches @ 2010-12-14  3:53 UTC (permalink / raw)
  To: Henry Ptasinski; +Cc: netdev, Brett Rudley, Dowan Kim, arend, rvossen

On Mon, 2010-12-13 at 17:49 -0800, Henry Ptasinski wrote:
> On Mon, Dec 13, 2010 at 04:47:47PM -0800, Joe Perches wrote:
> > LARQ seems to be used by Broadcom's staging driver.
> > Might as well add a #define for it to the normal location.
> > diff --git a/include/linux/if_ether.h b/include/linux/if_ether.h
[]
> > +#define ETH_P_LARQ	0x886c		/* HPNA / Broadcom
> That should be ETH_P_BRCM (or ETH_P_EPIGRAM).  HPNA/ILCP used a range of
> subtypes for LARQ and other HPNA protocols.  The brcmfmac driver uses a
> different subypte for encapsulating some event signals between the device and
> the host, but doesn't implement any of the HPNA protocols.

Another choice might be ETH_P_LINK_CTL



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [RFC PATCH net-next] if_ether.h: Add #define ETH_P_LARQ for HPNA/LARQ
  2010-12-14  3:53   ` Joe Perches
@ 2010-12-15 21:22     ` Henry Ptasinski
  2011-01-05  2:07     ` [PATCH] include/linux/if_ether.h: Add #define ETH_P_LINK_CTL for HPNA and wlan local tunnel Henry Ptasinski
  1 sibling, 0 replies; 6+ messages in thread
From: Henry Ptasinski @ 2010-12-15 21:22 UTC (permalink / raw)
  To: Joe Perches
  Cc: netdev, Brett Rudley, Dowan Kim, Arend Van Spriel, Roland Vossen

On Mon, Dec 13, 2010 at 07:53:51PM -0800, Joe Perches wrote:
> On Mon, 2010-12-13 at 17:49 -0800, Henry Ptasinski wrote:
> > On Mon, Dec 13, 2010 at 04:47:47PM -0800, Joe Perches wrote:
> > > LARQ seems to be used by Broadcom's staging driver.
> > > Might as well add a #define for it to the normal location.
> > > diff --git a/include/linux/if_ether.h b/include/linux/if_ether.h
> []
> > > +#define ETH_P_LARQ	0x886c		/* HPNA / Broadcom
> > That should be ETH_P_BRCM (or ETH_P_EPIGRAM).  HPNA/ILCP used a range of
> > subtypes for LARQ and other HPNA protocols.  The brcmfmac driver uses a
> > different subypte for encapsulating some event signals between the device and
> > the host, but doesn't implement any of the HPNA protocols.
> 
> Another choice might be ETH_P_LINK_CTL
> 

That would be fine too.

- Henry


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] include/linux/if_ether.h: Add #define ETH_P_LINK_CTL for HPNA and wlan local tunnel
  2010-12-14  3:53   ` Joe Perches
  2010-12-15 21:22     ` Henry Ptasinski
@ 2011-01-05  2:07     ` Henry Ptasinski
  2011-01-06 19:10       ` David Miller
  1 sibling, 1 reply; 6+ messages in thread
From: Henry Ptasinski @ 2011-01-05  2:07 UTC (permalink / raw)
  To: davem, joe; +Cc: henryp, brudley, arend, rvossen, dowan, netdev

Ethertype used by HPNA control protocols (LARQ, rate, link, etc) and by
Broadcom wlan drivers for local signalling.

Signed-off-by: Henry Ptasinski <henryp@broadcom.com>
---
 include/linux/if_ether.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/include/linux/if_ether.h b/include/linux/if_ether.h
index f9c3df0..be69043 100644
--- a/include/linux/if_ether.h
+++ b/include/linux/if_ether.h
@@ -72,6 +72,7 @@
 #define ETH_P_MPLS_UC	0x8847		/* MPLS Unicast traffic		*/
 #define ETH_P_MPLS_MC	0x8848		/* MPLS Multicast traffic	*/
 #define ETH_P_ATMMPOA	0x884c		/* MultiProtocol Over ATM	*/
+#define ETH_P_LINK_CTL	0x886c		/* HPNA, wlan link local tunnel */
 #define ETH_P_ATMFATE	0x8884		/* Frame-based ATM Transport
 					 * over Ethernet
 					 */
-- 
1.7.1



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] include/linux/if_ether.h: Add #define ETH_P_LINK_CTL for HPNA and wlan local tunnel
  2011-01-05  2:07     ` [PATCH] include/linux/if_ether.h: Add #define ETH_P_LINK_CTL for HPNA and wlan local tunnel Henry Ptasinski
@ 2011-01-06 19:10       ` David Miller
  0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2011-01-06 19:10 UTC (permalink / raw)
  To: henryp; +Cc: joe, brudley, arend, rvossen, dowan, netdev

From: "Henry Ptasinski" <henryp@broadcom.com>
Date: Tue, 4 Jan 2011 18:07:14 -0800

> Ethertype used by HPNA control protocols (LARQ, rate, link, etc) and by
> Broadcom wlan drivers for local signalling.
> 
> Signed-off-by: Henry Ptasinski <henryp@broadcom.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2011-01-06 19:09 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-14  0:47 [RFC PATCH net-next] if_ether.h: Add #define ETH_P_LARQ for HPNA/LARQ Joe Perches
2010-12-14  1:49 ` Henry Ptasinski
2010-12-14  3:53   ` Joe Perches
2010-12-15 21:22     ` Henry Ptasinski
2011-01-05  2:07     ` [PATCH] include/linux/if_ether.h: Add #define ETH_P_LINK_CTL for HPNA and wlan local tunnel Henry Ptasinski
2011-01-06 19:10       ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).