From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: shemminger@vyatta.com, netdev@vger.kernel.org
Subject: Re: [PATCH] ipv4: IP defragmentation must be ECN aware
Date: Thu, 06 Jan 2011 11:21:03 -0800 (PST) [thread overview]
Message-ID: <20110106.112103.59674935.davem@davemloft.net> (raw)
In-Reply-To: <1294249975.10633.74.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 05 Jan 2011 18:52:55 +0100
> [PATCH v2] ipv4: IP defragmentation must be ECN aware
>
> RFC3168 (The Addition of Explicit Congestion Notification to IP)
> states :
>
> 5.3. Fragmentation
>
> ECN-capable packets MAY have the DF (Don't Fragment) bit set.
> Reassembly of a fragmented packet MUST NOT lose indications of
> congestion. In other words, if any fragment of an IP packet to be
> reassembled has the CE codepoint set, then one of two actions MUST be
> taken:
>
> * Set the CE codepoint on the reassembled packet. However, this
> MUST NOT occur if any of the other fragments contributing to
> this reassembly carries the Not-ECT codepoint.
>
> * The packet is dropped, instead of being reassembled, for any
> other reason.
>
> This patch implements this requirement for IPv4, choosing the first
> action :
>
> If one fragment had NO-ECT codepoint
> reassembled frame has NO-ECT
> ElIf one fragment had CE codepoint
> reassembled frame has CE
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks a lot Eric.
prev parent reply other threads:[~2011-01-06 19:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-05 0:13 [RFC] ECN and IP defragmentation Eric Dumazet
2011-01-05 2:53 ` David Miller
2011-01-05 13:59 ` [PATCH] ipv4: IP defragmentation must be ECN aware Eric Dumazet
2011-01-05 17:13 ` Stephen Hemminger
2011-01-05 17:41 ` Eric Dumazet
2011-01-05 17:48 ` Stephen Hemminger
2011-01-05 17:52 ` Eric Dumazet
2011-01-06 19:21 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110106.112103.59674935.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).