From: David Miller <davem@davemloft.net>
To: xiaosuo@gmail.com
Cc: shemminger@linux-foundation.org,
bridge@lists.linux-foundation.org, netdev@vger.kernel.org
Subject: Re: [PATCH] net: bridge: check the length of skb after nf_bridge_maybe_copy_header()
Date: Thu, 06 Jan 2011 11:33:20 -0800 (PST) [thread overview]
Message-ID: <20110106.113320.28809548.davem@davemloft.net> (raw)
In-Reply-To: <AANLkTikb+o2tXg0uU92Q9foVqX2P49dhJX+umLX=Nhfn@mail.gmail.com>
From: Changli Gao <xiaosuo@gmail.com>
Date: Wed, 5 Jan 2011 21:37:28 +0800
> On Tue, Jan 4, 2011 at 4:13 AM, David Miller <davem@davemloft.net> wrote:
>> From: Stephen Hemminger <shemminger@linux-foundation.org>
>>>
>>> Because PPPOE happens afterwards and is not part the calculation.
>>> The check should be moved until after skb has reached final form.
>>
>> That works for me.
>>
>
> So, is my patch acceptable?
Yes, I've applied it, thank you.
prev parent reply other threads:[~2011-01-06 19:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-25 13:41 [PATCH] net: bridge: check the length of skb after nf_bridge_maybe_copy_header() Changli Gao
2010-12-31 19:10 ` David Miller
2011-01-03 10:44 ` Changli Gao
2011-01-03 17:22 ` David Miller
2011-01-03 18:15 ` Stephen Hemminger
2011-01-03 20:13 ` David Miller
2011-01-05 13:37 ` Changli Gao
2011-01-06 19:33 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110106.113320.28809548.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bridge@lists.linux-foundation.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).