From: Kurt Van Dijck <kurt.van.dijck-/BeEPy95v10@public.gmane.org>
To: Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
Cc: socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH net-next-2.6 v2 2/2] can: add driver for Softing card
Date: Thu, 6 Jan 2011 07:26:36 +0100 [thread overview]
Message-ID: <20110106062635.GA375@e-circ.dyndns.org> (raw)
In-Reply-To: <4D24DC58.7090009-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
On Wed, Jan 05, 2011 at 10:02:16PM +0100, Wolfgang Grandegger wrote:
> > +
> > +config CAN_SOFTING_CS
> > + tristate "Softing CAN pcmcia cards"
> > + depends on PCMCIA
>
> Does it not also depend on CAN_SOFTING?
>
IMO not in a way that requires a depends here.
As a user, when I use the card, I definitely will want CAN_SOFTING,
since CAN_SOFTING_CS will only create a platform device as abstraction
of the DPRAM interface.
CAN_SOFTING will then create the CAN network devices on top of that,
but there is no object dependancy.
That's different than with SJA1000.
Kurt
prev parent reply other threads:[~2011-01-06 6:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-04 15:05 [PATCH net-next-2.6 v2 0/2] can: add driver for Softing card Kurt Van Dijck
[not found] ` <20110104150513.GA321-MxZ6Iy/zr/UdbCeoMzGj59i2O/JbrIOy@public.gmane.org>
2011-01-04 15:07 ` [PATCH net-next-2.6 v2 1/2] " Kurt Van Dijck
[not found] ` <20110104150759.GB321-MxZ6Iy/zr/UdbCeoMzGj59i2O/JbrIOy@public.gmane.org>
2011-01-05 20:57 ` Wolfgang Grandegger
2011-01-06 15:05 ` Kurt Van Dijck
[not found] ` <20110106150525.GB324-MxZ6Iy/zr/UdbCeoMzGj59i2O/JbrIOy@public.gmane.org>
2011-01-06 16:27 ` Wolfgang Grandegger
[not found] ` <4D25ED70.7000303-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2011-01-07 12:29 ` Kurt Van Dijck
[not found] ` <4D24DB2C.9040104-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2011-01-10 13:31 ` Kurt Van Dijck
[not found] ` <20110110133112.GA324-MxZ6Iy/zr/UdbCeoMzGj59i2O/JbrIOy@public.gmane.org>
2011-01-10 13:40 ` Wolfram Sang
[not found] ` <20110110134006.GC31011-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-01-10 13:44 ` Kurt Van Dijck
2011-01-10 14:05 ` Wolfgang Grandegger
[not found] ` <4D2B1245.9060303-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2011-01-10 14:07 ` Wolfgang Grandegger
2011-01-10 14:40 ` Kurt Van Dijck
2011-01-04 15:09 ` [PATCH net-next-2.6 v2 2/2] " Kurt Van Dijck
[not found] ` <20110104150923.GC321-MxZ6Iy/zr/UdbCeoMzGj59i2O/JbrIOy@public.gmane.org>
2011-01-05 21:02 ` Wolfgang Grandegger
[not found] ` <4D24DC58.7090009-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2011-01-06 6:26 ` Kurt Van Dijck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110106062635.GA375@e-circ.dyndns.org \
--to=kurt.van.dijck-/beepy95v10@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org \
--cc=wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).