From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kurt Van Dijck Subject: Re: [PATCH net-next-2.6 v2 2/2] can: add driver for Softing card Date: Thu, 6 Jan 2011 07:26:36 +0100 Message-ID: <20110106062635.GA375@e-circ.dyndns.org> References: <20110104150513.GA321@e-circ.dyndns.org> <20110104150923.GC321@e-circ.dyndns.org> <4D24DC58.7090009@grandegger.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Wolfgang Grandegger Return-path: Content-Disposition: inline In-Reply-To: <4D24DC58.7090009-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org Errors-To: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org List-Id: netdev.vger.kernel.org On Wed, Jan 05, 2011 at 10:02:16PM +0100, Wolfgang Grandegger wrote: > > + > > +config CAN_SOFTING_CS > > + tristate "Softing CAN pcmcia cards" > > + depends on PCMCIA > > Does it not also depend on CAN_SOFTING? > IMO not in a way that requires a depends here. As a user, when I use the card, I definitely will want CAN_SOFTING, since CAN_SOFTING_CS will only create a platform device as abstraction of the DPRAM interface. CAN_SOFTING will then create the CAN network devices on top of that, but there is no object dependancy. That's different than with SJA1000. Kurt