From: Stephen Hemminger <shemminger@vyatta.com>
To: David Miller <davem@davemloft.net>
Cc: Haiyang Zhang <haiyangz@microsoft.com>,
Hank Janssen <hjanssen@microsoft.com>,
Mike Sterling <Mike.Sterling@microsoft.com>,
netdev@vger.kernel.org,
<virtualization@lists.linux-foundation.org>
Subject: [PATCH] hv: don't enable Scatter/Gather
Date: Thu, 6 Jan 2011 12:28:27 -0800 [thread overview]
Message-ID: <20110106122827.733b5438@nehalam> (raw)
In-Reply-To: <1FB5E1D5CA062146B38059374562DF729555F841@TK5EX14MBXC121.redmond.corp.microsoft.com>
The HyperV network driver can do scatter/gather but does not
do checksum offload. Since the network stack requires checksum offload
to do direct transmit (sendfile), netdev_register produces a message
when driver is loaded.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/drivers/staging/hv/netvsc_drv.c 2011-01-06 12:23:48.143333212 -0800
+++ b/drivers/staging/hv/netvsc_drv.c 2011-01-06 12:24:10.447744121 -0800
@@ -390,8 +390,6 @@ static int netvsc_probe(struct device *d
net->netdev_ops = &device_ops;
/* TODO: Add GSO and Checksum offload */
- net->features = NETIF_F_SG;
-
SET_ETHTOOL_OPS(net, ðtool_ops);
SET_NETDEV_DEV(net, device);
parent reply other threads:[~2011-01-06 20:28 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1FB5E1D5CA062146B38059374562DF729555F841@TK5EX14MBXC121.redmond.corp.microsoft.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110106122827.733b5438@nehalam \
--to=shemminger@vyatta.com \
--cc=Mike.Sterling@microsoft.com \
--cc=davem@davemloft.net \
--cc=haiyangz@microsoft.com \
--cc=hjanssen@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).