From: Paul Mackerras <paulus@samba.org>
To: Changli Gao <xiaosuo@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Harvey Harrison <harvey.harrison@gmail.com>,
linux-ppp@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2] net: ppp: use {get,put}_unaligned_be{16,32}
Date: Fri, 7 Jan 2011 14:01:45 +1100 [thread overview]
Message-ID: <20110107030145.GA8021@brick.ozlabs.ibm.com> (raw)
In-Reply-To: <1294357056-25889-1-git-send-email-xiaosuo@gmail.com>
On Fri, Jan 07, 2011 at 07:37:36AM +0800, Changli Gao wrote:
> Signed-off-by: Changli Gao <xiaosuo@gmail.com>
This patch description is inadequate. It should tell us why you are
making this change. Does it result in smaller and/or faster code, and
if so by how much on what sort of machine? Do you think it makes the
code clearer? (I don't.) Or is there some other motivation for this?
Paul.
next prev parent reply other threads:[~2011-01-07 3:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-06 23:37 [PATCH v2] net: ppp: use {get,put}_unaligned_be{16,32} Changli Gao
2011-01-06 23:42 ` Harvey Harrison
2011-01-07 3:01 ` Paul Mackerras [this message]
2011-01-08 0:43 ` Changli Gao
2011-01-08 1:15 ` David Miller
2011-01-08 3:13 ` Paul Mackerras
2011-01-08 4:37 ` David Miller
2011-01-08 10:04 ` Jarek Poplawski
2011-01-08 10:20 ` Eric Dumazet
2011-01-08 10:33 ` Jarek Poplawski
2011-01-11 0:13 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110107030145.GA8021@brick.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=davem@davemloft.net \
--cc=harvey.harrison@gmail.com \
--cc=linux-ppp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).