netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anton Blanchard <anton@samba.org>
To: leitao@linux.vnet.ibm.com
Cc: joe@perches.com, netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH] ehea: Add some info messages and fix an issue
Date: Fri, 7 Jan 2011 14:24:30 +1100	[thread overview]
Message-ID: <20110107142430.42fda498@kryten> (raw)
In-Reply-To: <1290792387-12331-1-git-send-email-leitao@linux.vnet.ibm.com>

Hi,

> From: Breno Leitao <breno@cafe.(none)>
> 
> This patch adds some debug information about ehea not being able to
> allocate enough spaces. Also it correctly updates the amount of
> available skb.

I'm seeing issues on a number of machines with the ehea device.
Sometime after boot I see a bunch of:

ehea: Error in ehea_proc_rwqes: LL rq1: skb=NULL
ehea: Error in ehea_proc_rwqes: LL rq1: skb=NULL
ehea: Error in ehea_proc_rwqes: LL rq1: skb=NULL
ehea: Error in ehea_proc_rwqes: LL rq1: skb=NULL

which eventually stop.

-       for (i = 0; i < pr->rq1_skba.len; i++) {
+       for (i = 0; i < nr_rq1a; i++) {

It looks like you are now only initialising half the ring, but still
telling the hardware to use the whole ring. Once you get through the
entire ring once the errors go away.

Anton

  parent reply	other threads:[~2011-01-07  3:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-26 16:26 [PATCH] ehea: Add some info messages and fix an issue leitao
2010-11-26 17:01 ` Joe Perches
2010-11-26 17:26   ` leitao
2010-11-26 23:27     ` [PATCH] ehea: Use the standard logging functions Joe Perches
2010-11-30 17:03       ` Breno Leitao
2010-11-30 18:18         ` [net-next PATCH V2] " Joe Perches
2010-12-02 18:54           ` Breno Leitao
2010-12-06 21:02             ` David Miller
2010-11-29  2:15     ` [PATCH] ehea: Add some info messages and fix an issue David Miller
2011-01-07  3:24     ` Anton Blanchard [this message]
2011-01-07 12:14       ` Breno Leitao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110107142430.42fda498@kryten \
    --to=anton@samba.org \
    --cc=davem@davemloft.net \
    --cc=joe@perches.com \
    --cc=leitao@linux.vnet.ibm.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).