From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH v2] Madge Ambassador ATM Adapter driver: Always
 release_firmware() in ucode_init() and don't leak memory.
Date: Sun, 09 Jan 2011 15:46:01 -0800 (PST)
Message-ID: <20110109.154601.116374791.davem@davemloft.net>
References: <alpine.LNX.2.00.1101062203160.13988@swampdragon.chaosbits.net>
	<20110107100239.28032e5d@thirdoffive.cmf.nrl.navy.mil>
	<alpine.LNX.2.00.1101092229160.633@swampdragon.chaosbits.net>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: chas@cmf.nrl.navy.mil, linux-atm-general@lists.sourceforge.net,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
To: jj@chaosbits.net
Return-path: <netdev-owner@vger.kernel.org>
Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:46382
	"EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1753149Ab1AIXp3 (ORCPT
	<rfc822;netdev@vger.kernel.org>); Sun, 9 Jan 2011 18:45:29 -0500
In-Reply-To: <alpine.LNX.2.00.1101092229160.633@swampdragon.chaosbits.net>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Jesper Juhl <jj@chaosbits.net>
Date: Sun, 9 Jan 2011 22:32:38 +0100 (CET)

> Failure to call release_firmware() will result in memory leak in
> drivers/atm/ambassador.c::ucode_init().
> This patch makes sure we always call release_firmware() when needed, 
> thus removing the leak(s).
> 
> Yes, I know checkpatch complains about this patch, but it was either that 
> or completely mess up the existing style, so I opted to use the existing 
> style and live with the checkpatch related flak.
> 
> 
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>

Applied.