From: David Miller <davem@davemloft.net>
To: error27@gmail.com
Cc: remi.denis-courmont@nokia.com, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, dan.j.rosenberg@gmail.com
Subject: Re: [patch] phonet: some signedness bugs
Date: Sun, 09 Jan 2011 18:13:36 -0800 (PST) [thread overview]
Message-ID: <20110109.181336.91348184.davem@davemloft.net> (raw)
In-Reply-To: <20110109.164548.58428218.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Sun, 09 Jan 2011 16:45:48 -0800 (PST)
> From: Dan Carpenter <error27@gmail.com>
> Date: Fri, 7 Jan 2011 23:37:55 +0300
>
>> Dan Rosenberg pointed out that there were some signed comparison bugs
>> in the phonet protocol.
>>
>> http://marc.info/?l=full-disclosure&m=129424528425330&w=2
>>
>> If you have already have CAP_SYS_ADMIN then you could use the bugs to
>> get root, or someone could cause an oops by mistake.
>>
>> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> Applied and queued up for -stable, thanks Dan.
Actually I'm reverting this.
You can't change the prototype of pn_socket_create() because if you do
then it doesn't match up with the prototype required by
net_proto_family->create().
You didn't see this warning in your build?
net/phonet/af_phonet.c:124:2: warning: initialization from incompatible pointer type
next prev parent reply other threads:[~2011-01-10 2:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-07 20:37 [patch] phonet: some signedness bugs Dan Carpenter
2011-01-10 0:45 ` David Miller
2011-01-10 2:13 ` David Miller [this message]
2011-01-10 7:58 ` Rémi Denis-Courmont
2011-01-10 14:01 ` Dan Carpenter
2011-01-10 14:08 ` Rémi Denis-Courmont
2011-01-10 14:06 ` [patch v2] " Dan Carpenter
2011-01-10 14:12 ` Rémi Denis-Courmont
2011-01-11 0:06 ` David Miller
2011-01-13 12:32 ` Rémi Denis-Courmont
2011-01-13 20:30 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110109.181336.91348184.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dan.j.rosenberg@gmail.com \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=remi.denis-courmont@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).