From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [patch] phonet: some signedness bugs Date: Sun, 09 Jan 2011 18:13:36 -0800 (PST) Message-ID: <20110109.181336.91348184.davem@davemloft.net> References: <20110107203755.GB1959@bicker> <20110109.164548.58428218.davem@davemloft.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: remi.denis-courmont@nokia.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, dan.j.rosenberg@gmail.com To: error27@gmail.com Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:47491 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750942Ab1AJCNG (ORCPT ); Sun, 9 Jan 2011 21:13:06 -0500 In-Reply-To: <20110109.164548.58428218.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: From: David Miller Date: Sun, 09 Jan 2011 16:45:48 -0800 (PST) > From: Dan Carpenter > Date: Fri, 7 Jan 2011 23:37:55 +0300 > >> Dan Rosenberg pointed out that there were some signed comparison bugs >> in the phonet protocol. >> >> http://marc.info/?l=full-disclosure&m=129424528425330&w=2 >> >> If you have already have CAP_SYS_ADMIN then you could use the bugs to >> get root, or someone could cause an oops by mistake. >> >> Signed-off-by: Dan Carpenter > > Applied and queued up for -stable, thanks Dan. Actually I'm reverting this. You can't change the prototype of pn_socket_create() because if you do then it doesn't match up with the prototype required by net_proto_family->create(). You didn't see this warning in your build? net/phonet/af_phonet.c:124:2: warning: initialization from incompatible pointer type