netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@vyatta.com>
To: Alex Dubov <oakad@yahoo.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
	netdev@vger.kernel.org, David Miller <davem@davemloft.net>
Subject: Re: Bad TCP timestamps on non-PC platforms
Date: Sun, 9 Jan 2011 19:57:11 -0800	[thread overview]
Message-ID: <20110109195711.1d622b2e@nehalam> (raw)
In-Reply-To: <798351.95533.qm@web37603.mail.mud.yahoo.com>

On Sun, 9 Jan 2011 19:41:13 -0800 (PST)
Alex Dubov <oakad@yahoo.com> wrote:

> > > 
> > > You dont give new informations ;)
> > > 
> 
> Some additional information (my wireshark was not validating checksums, so
> I missed the real culprit).
> 
> It so appears, that when timestamps are enabled on my dev board, TCP
> checksum in SYN packet turns out to be incorrect. That's why those packets
> are dropped by the remote side. When TCP timestamps are disabled, checksums
> are correct.
> 
> Any ideas where this particular problem may originate?

Is there a bug in checksum offload in the driver?
Does the hardware correctly handle checksum of packets that are
unaligned or whose length is an odd number of bytes?

If the hardware can't do checksum correctly, the driver should either
disable checksum offload or in worst case copy the packet to a new
buffer that is in a known safe place.

  reply	other threads:[~2011-01-10  3:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-10  3:41 Bad TCP timestamps on non-PC platforms Alex Dubov
2011-01-10  3:57 ` Stephen Hemminger [this message]
2011-01-10  6:33   ` Alex Dubov
2011-01-10  7:07     ` Eric Dumazet
2011-01-10  7:19       ` David Miller
  -- strict thread matches above, loose matches on Subject: below --
2011-01-06  6:55 Alex Dubov
2011-01-06  8:09 ` Eric Dumazet
2011-01-07  1:55   ` Alex Dubov
2011-01-07  2:11     ` Eric Dumazet
2011-01-07  6:39       ` Alex Dubov
2011-01-06 16:44 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110109195711.1d622b2e@nehalam \
    --to=shemminger@vyatta.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=oakad@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).