From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: shemminger@vyatta.com, jarkao2@gmail.com, xiaosuo@gmail.com,
fabio@gandalf.sssup.it, netdev@vger.kernel.org,
rizzo@iet.unipi.it
Subject: Re: [PATCH] net_sched: factorize qdisc stats handling
Date: Mon, 10 Jan 2011 16:08:15 -0800 (PST) [thread overview]
Message-ID: <20110110.160815.148553725.davem@davemloft.net> (raw)
In-Reply-To: <1294597854.2709.850.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sun, 09 Jan 2011 19:30:54 +0100
> [PATCH v2] net_sched: factorize qdisc stats handling
>
> HTB takes into account skb is segmented in stats updates.
> Generalize this to all schedulers.
>
> They should use qdisc_bstats_update() helper instead of manipulating
> bstats.bytes and bstats.packets
>
> Add bstats_update() helper too for classes that use
> gnet_stats_basic_packed fields.
>
> Note : Right now, TCQ_F_CAN_BYPASS shortcurt can be taken only if no
> stab is setup on qdisc.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> ---
> v2: constify some methods, and make sure qdisc_skb_cb(skb)->pkt_len is
> set in the TCQ_F_CAN_BYPASS shortcut in __dev_xmit_skb()
Applied, thanks Eric.
next prev parent reply other threads:[~2011-01-11 0:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-07 3:56 [RFC] sched: QFQ - quick fair queue scheduler Stephen Hemminger
2011-01-07 19:24 ` [RFC] sched: QFQ - quick fair queue scheduler (iproute2) Stephen Hemminger
2011-01-08 2:56 ` [RFC] sched: QFQ - quick fair queue scheduler Changli Gao
2011-01-08 4:02 ` Stephen Hemminger
2011-01-08 9:26 ` [PATCH] net_sched: factorize qdisc stats handling Eric Dumazet
2011-01-08 13:35 ` Jarek Poplawski
2011-01-08 15:40 ` Eric Dumazet
2011-01-09 17:57 ` Stephen Hemminger
2011-01-09 18:30 ` Eric Dumazet
2011-01-11 0:08 ` David Miller [this message]
2011-01-17 21:55 ` Jesper Dangaard Brouer
2011-01-17 22:04 ` Eric Dumazet
2011-01-08 4:34 ` [RFC] sched: QFQ - quick fair queue scheduler David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110110.160815.148553725.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=fabio@gandalf.sssup.it \
--cc=jarkao2@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rizzo@iet.unipi.it \
--cc=shemminger@vyatta.com \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).