From: Dan Carpenter <error27@gmail.com>
To: "Rémi Denis-Courmont" <remi.denis-courmont@nokia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
dan.j.rosenberg@gmail.com
Subject: Re: [patch] phonet: some signedness bugs
Date: Mon, 10 Jan 2011 17:01:41 +0300 [thread overview]
Message-ID: <20110110140141.GA2721@bicker> (raw)
In-Reply-To: <201101100958.32549.remi.denis-courmont@nokia.com>
On Mon, Jan 10, 2011 at 09:58:32AM +0200, Rémi Denis-Courmont wrote:
> On Friday 07 January 2011 22:37:55 ext Dan Carpenter, you wrote:
> > Dan Rosenberg pointed out that there were some signed comparison bugs
> > in the phonet protocol.
>
> There are two ways to solve this: change *only* the proto_get function to use
> an unsigned parameter, or cast the protocol to unsigned in the comparison.
>
> As David pointed out, your patch breaks the socket() callback prototype.
>
Yes. I really appologize for that. I'll send version 2 with that create()
change dropped. It's not needed.
I would like to keep the change to phonet_proto_register() because the
check in there isn't right and it's similar to phonet_proto_get(). We
may as well keep phonet_proto_unregister() as well so it's symmetric.
Let me know if you disagree and I'll redo it.
regards,
dan carpenter
next prev parent reply other threads:[~2011-01-10 14:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-07 20:37 [patch] phonet: some signedness bugs Dan Carpenter
2011-01-10 0:45 ` David Miller
2011-01-10 2:13 ` David Miller
2011-01-10 7:58 ` Rémi Denis-Courmont
2011-01-10 14:01 ` Dan Carpenter [this message]
2011-01-10 14:08 ` Rémi Denis-Courmont
2011-01-10 14:06 ` [patch v2] " Dan Carpenter
2011-01-10 14:12 ` Rémi Denis-Courmont
2011-01-11 0:06 ` David Miller
2011-01-13 12:32 ` Rémi Denis-Courmont
2011-01-13 20:30 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110110140141.GA2721@bicker \
--to=error27@gmail.com \
--cc=dan.j.rosenberg@gmail.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=remi.denis-courmont@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).