From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: daniel.baluta@gmail.com, gasparch@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH] tcp: disallow bind() to reuse addr/port
Date: Tue, 11 Jan 2011 14:03:36 -0800 (PST) [thread overview]
Message-ID: <20110111.140336.128591591.davem@davemloft.net> (raw)
In-Reply-To: <1294744462.2927.53.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 11 Jan 2011 12:14:22 +0100
> [PATCH] tcp: disallow bind() to reuse addr/port
>
> inet_csk_bind_conflict() logic currently disallows a bind() if
> it finds a friend socket (a socket bound on same address/port)
> satisfying a set of conditions :
>
> 1) Current (to be bound) socket doesnt have sk_reuse set
> OR
> 2) other socket doesnt have sk_reuse set
> OR
> 3) other socket is in LISTEN state
>
> We should add the CLOSE state in the 3) condition, in order to avoid two
> REUSEADDR sockets in CLOSE state with same local address/port, since
> this can deny further operations.
>
> Note : a prior patch tried to address the problem in a different (and
> buggy) way. (commit fda48a0d7a8412ced tcp: bind() fix when many ports
> are bound).
>
> Reported-by: Gaspar Chilingarov <gasparch@gmail.com>
> Reported-by: Daniel Baluta <daniel.baluta@gmail.com>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks.
next prev parent reply other threads:[~2011-01-11 22:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-04 8:53 'tcp: bind() fix when many ports are bound' problem Daniel Baluta
2011-01-04 9:12 ` Gaspar Chilingarov
2011-01-04 11:22 ` Eric Dumazet
2011-01-05 9:00 ` Daniel Baluta
2011-01-11 11:14 ` [PATCH] tcp: disallow bind() to reuse addr/port Eric Dumazet
2011-01-11 13:04 ` Daniel Baluta
2011-01-11 22:03 ` David Miller [this message]
2011-04-27 17:37 ` George B.
2011-04-27 17:40 ` Eric Dumazet
2011-04-27 17:54 ` George B.
2011-04-27 18:02 ` Eric Dumazet
2011-04-27 18:45 ` George B.
2011-04-27 17:36 ` 'tcp: bind() fix when many ports are bound' problem George B.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110111.140336.128591591.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=daniel.baluta@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=gasparch@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).