From: Vlad Dogaru <ddvlad@rosedu.org>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, hadi@cyberus.ca, opurdila@ixiacom.com
Subject: Re: [PATCH 2/3] net/dummy: add device group parameter
Date: Tue, 11 Jan 2011 14:17:46 +0200 [thread overview]
Message-ID: <20110111121746.GC26417@cormyr> (raw)
In-Reply-To: <20110110.133748.85424564.davem@davemloft.net>
On Mon, Jan 10, 2011 at 01:37:48PM -0800, David Miller wrote:
> From: Vlad Dogaru <ddvlad@rosedu.org>
> Date: Mon, 10 Jan 2011 13:38:43 +0200
>
> > When inserting the dummy module, the user can specify the group of the
> > dummy devices. This avoids manually moving the newly created pseudo
> > devices to a different group.
> >
> > Signed-off-by: Vlad Dogaru <ddvlad@rosedu.org>
>
> The amount of hacks people wish to add to the dummy driver is one step
> away from amazing.
>
> Just use the standard APIs to add dummy devices to the group you want,
> instead of these ad-hoc device specific module parameters.
Sorry for attempting to bloat the dummy module. The intention was to be
able to add many dummy interfaces directly into a group without much
user-kernel communication.
However, I think that can be done by moving the existing (hopefully few)
interfaces to another group prior to adding the dummies to group 0 and
using that to manipulate them.
Vlad
next prev parent reply other threads:[~2011-01-11 12:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-10 11:38 [PATCH 0/3] net: add device groups Vlad Dogaru
2011-01-10 11:38 ` [PATCH 1/3] net_device: add support for network " Vlad Dogaru
2011-01-10 11:38 ` [PATCH 2/3] net/dummy: add device group parameter Vlad Dogaru
2011-01-10 21:37 ` David Miller
2011-01-11 12:17 ` Vlad Dogaru [this message]
2011-01-10 11:38 ` [PATCH 3/3] netlink: support setting devgroup parameters Vlad Dogaru
2011-01-10 13:14 ` jamal
2011-01-11 12:13 ` Vlad Dogaru
2011-01-11 12:40 ` jamal
2011-01-10 13:41 ` [PATCH 0/3] net: add device groups Johannes Berg
2011-01-10 14:00 ` jamal
2011-01-10 14:08 ` Johannes Berg
2011-01-10 14:24 ` jamal
2011-01-10 14:38 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110111121746.GC26417@cormyr \
--to=ddvlad@rosedu.org \
--cc=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=netdev@vger.kernel.org \
--cc=opurdila@ixiacom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).