From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Greg Ungerer <gerg@snapgear.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
Shawn Guo <shawn.guo@freescale.com>,
B32542@freescale.com, netdev@vger.kernel.org,
jamie@shareable.org, baruch@tkos.co.il, w.sang@pengutronix.de,
r64343@freescale.com, eric@eukrea.com, bryan.wu@canonical.com,
jamie@jamieiles.com, davem@davemloft.net,
linux-arm-kernel@lists.infradead.org, lw@karo-electronics.de
Subject: Re: [PATCH v4 05/10] net/fec: add dual fec support for mx28
Date: Tue, 11 Jan 2011 14:07:50 +0100 [thread overview]
Message-ID: <20110111130749.GQ24920@pengutronix.de> (raw)
In-Reply-To: <4D2C4BEC.1030003@snapgear.com>
Hi Greg,
On Tue, Jan 11, 2011 at 10:24:12PM +1000, Greg Ungerer wrote:
> On 11/01/11 20:27, Sascha Hauer wrote:
> >On Thu, Jan 06, 2011 at 03:13:13PM +0800, Shawn Guo wrote:
> >This option is used nowhere and should be removed. Certainly it does not
> >have the effect of enabling the second ethernet controller.
>
> It does for a ColdFire platform...
>
> grep -r CONFIG_FEC2 *
>
> arch/m68knommu/configs/m5275evb_defconfig:CONFIG_FEC2=y
> arch/m68knommu/platform/527x/config.c:#ifdef CONFIG_FEC2
> arch/m68knommu/platform/527x/config.c:#ifdef CONFIG_FEC2
IMHO Sascha's comment[1] applies here, too.
And someone might want to do what he suggested soon or the patch
removing CONFIG_FEC2[2] needs to be commented accordingly.
Best regards
Uwe
[1] http://thread.gmane.org/gmane.linux.network/182929/focus=183378
[2] http://mid.gmane.org/1294747672-4433-1-git-send-email-shawn.guo@freescale.com
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2011-01-11 13:07 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-06 7:13 [PATCH v4 00/10] net/fec: add dual fec support for i.MX28 Shawn Guo
2011-01-06 7:13 ` [PATCH v4 01/10] net/fec: fix MMFR_OP type in fec_enet_mdio_write Shawn Guo
2011-01-06 7:13 ` [PATCH v4 02/10] net/fec: remove the use of "index" which is legacy Shawn Guo
2011-01-06 7:13 ` [PATCH v4 03/10] net/fec: add mac field into platform data and consolidate fec_get_mac Shawn Guo
2011-01-06 7:13 ` [PATCH v4 04/10] net/fec: improve pm for better suspend/resume Shawn Guo
2011-01-06 7:13 ` [PATCH v4 05/10] net/fec: add dual fec support for mx28 Shawn Guo
2011-01-11 10:27 ` Sascha Hauer
2011-01-11 11:38 ` Shawn Guo
2011-01-11 12:24 ` Greg Ungerer
2011-01-11 13:07 ` Uwe Kleine-König [this message]
2011-01-11 13:25 ` Greg Ungerer
2011-01-12 7:42 ` Uwe Kleine-König
2011-01-13 14:48 ` Uwe Kleine-König
2011-01-14 5:48 ` Shawn Guo
2011-01-14 7:52 ` Uwe Kleine-König
2011-01-14 13:08 ` Shawn Guo
2011-01-17 8:16 ` Lothar Waßmann
2011-01-17 8:42 ` Uwe Kleine-König
2011-01-17 11:52 ` Shawn Guo
2011-01-17 9:06 ` Uwe Kleine-König
2011-01-13 21:06 ` Uwe Kleine-König
2011-01-06 7:13 ` [PATCH v4 06/10] ARM: mx28: update clock and device name for dual fec support Shawn Guo
2011-01-13 15:06 ` Uwe Kleine-König
2011-01-14 6:46 ` Shawn Guo
2011-01-14 6:53 ` [PATCH] ARM: mxs: pass fec device name via platform data Shawn Guo
2011-01-14 8:38 ` Uwe Kleine-König
2011-01-06 7:13 ` [PATCH v4 07/10] ARM: mx28: add the second fec device registration Shawn Guo
2011-01-11 10:29 ` Sascha Hauer
2011-01-11 11:39 ` Shawn Guo
2011-01-11 11:44 ` Sascha Hauer
2011-01-06 7:13 ` [PATCH v4 08/10] ARM: mxs: add ocotp read function Shawn Guo
2011-01-11 13:31 ` Sascha Hauer
2011-01-11 14:05 ` Uwe Kleine-König
2011-01-12 6:47 ` Shawn Guo
2011-01-12 14:50 ` Sascha Hauer
2011-01-12 16:01 ` Uwe Kleine-König
2011-01-13 1:55 ` Shawn Guo
2011-01-13 15:19 ` Uwe Kleine-König
2011-01-14 8:33 ` Sascha Hauer
2011-01-14 13:16 ` Shawn Guo
2011-01-19 10:48 ` Shawn Guo
2011-01-06 7:13 ` [PATCH v4 09/10] ARM: mx28: read fec mac address from ocotp Shawn Guo
2011-01-13 14:50 ` Uwe Kleine-König
2011-01-06 7:13 ` [PATCH v4 10/10] ARM: mxs: add initial pm support Shawn Guo
2011-01-09 23:44 ` [PATCH v4 00/10] net/fec: add dual fec support for i.MX28 David Miller
2011-01-10 3:08 ` Shawn Guo
2011-01-11 8:15 ` Shawn Guo
2011-01-11 12:07 ` [PATCH] net/fec: remove config FEC2 as it's used nowhere Shawn Guo
2011-01-11 22:03 ` David Miller
2011-01-11 12:09 ` [PATCH v5] ARM: mx28: add the second fec device registration Shawn Guo
2011-01-13 14:49 ` Uwe Kleine-König
2011-01-14 7:04 ` Shawn Guo
2011-01-14 7:24 ` [PATCH v5 08/10] ARM: mxs: add ocotp read function Shawn Guo
2011-01-14 8:40 ` Sascha Hauer
2011-01-14 9:48 ` Uwe Kleine-König
2011-01-14 8:42 ` Uwe Kleine-König
2011-01-14 7:25 ` [PATCH v5 09/10] ARM: mxs/mx28evk: read fec mac address from ocotp Shawn Guo
2011-01-14 15:11 ` [PATCH v6 08/10] ARM: mxs: add ocotp read function Shawn Guo
2011-01-24 9:05 ` [PATCH v5] ARM: mxs: add initial pm support Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110111130749.GQ24920@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=B32542@freescale.com \
--cc=baruch@tkos.co.il \
--cc=bryan.wu@canonical.com \
--cc=davem@davemloft.net \
--cc=eric@eukrea.com \
--cc=gerg@snapgear.com \
--cc=jamie@jamieiles.com \
--cc=jamie@shareable.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lw@karo-electronics.de \
--cc=netdev@vger.kernel.org \
--cc=r64343@freescale.com \
--cc=s.hauer@pengutronix.de \
--cc=shawn.guo@freescale.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).