From: Stephen Hemminger <shemminger@vyatta.com>
To: William Allen Simpson <william.allen.simpson@gmail.com>
Cc: Linux Kernel Developers <linux-kernel@vger.kernel.org>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v1 2/2] TCPCT API sockopt update to draft -03
Date: Wed, 12 Jan 2011 10:56:08 -0800 [thread overview]
Message-ID: <20110112105608.793787b2@s6510> (raw)
In-Reply-To: <4D2DEC0A.70608@gmail.com>
On Wed, 12 Jan 2011 12:59:38 -0500
William Allen Simpson <william.allen.simpson@gmail.com> wrote:
> diff --git a/include/linux/tcp.h b/include/linux/tcp.h
> index e64f4c6..c8f4017 100644
> --- a/include/linux/tcp.h
> +++ b/include/linux/tcp.h
> @@ -185,22 +185,37 @@ struct tcp_md5sig {
> #define TCP_COOKIE_PAIR_SIZE (2*TCP_COOKIE_MAX)
>
> /* Flags for both getsockopt and setsockopt */
> -#define TCP_COOKIE_IN_ALWAYS (1 << 0) /* Discard SYN without cookie */
> -#define TCP_COOKIE_OUT_NEVER (1 << 1) /* Prohibit outgoing cookies,
> +#define TCPCT_IN_ALWAYS (1 << 0) /* Discard SYN without cookie */
> +#define TCPCT_OUT_NEVER (1 << 1) /* Prohibit outgoing cookies,
You end up changing values in kernel userspace API in a way
that is incompatible with older applications. This is not acceptable.
next prev parent reply other threads:[~2011-01-12 18:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-12 17:43 TCPCT API update for 2.6.37 William Allen Simpson
2011-01-12 17:52 ` [PATCH v1 1/2] TCPCT API sysctl update to draft -03 William Allen Simpson
2011-01-12 18:05 ` Eric Dumazet
2011-01-12 17:59 ` [PATCH v1 2/2] TCPCT API sockopt " William Allen Simpson
2011-01-12 18:56 ` Stephen Hemminger [this message]
2011-01-13 17:32 ` William Allen Simpson
2011-01-13 17:53 ` Arnaud Lacombe
2011-01-14 3:00 ` William Allen Simpson
2011-01-14 3:08 ` Eric Dumazet
2011-01-13 18:00 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110112105608.793787b2@s6510 \
--to=shemminger@vyatta.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=william.allen.simpson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).