* [PATCH] vxge: Remember to release firmware after upgrading firmware
@ 2011-01-13 20:25 Jesper Juhl
2011-01-13 20:35 ` [PATCH] vxge: Remember to release firmware after upgrading firmware {nodisc} Ramkrishna Vepa
2011-01-14 5:50 ` [PATCH] vxge: Remember to release firmware after upgrading firmware David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Jesper Juhl @ 2011-01-13 20:25 UTC (permalink / raw)
To: netdev
Cc: linux-kernel, Ramkrishna Vepa, Jon Mason, Sivakumar Subramani,
Sreenivasa Honnur
Regardless of whether the firmware update being performed by
vxge_fw_upgrade() is a success or not we must still remember to always
release_firmware() before returning.
Signed-off-by: Jesper Juhl <jj@chaosbits.net>
---
vxge-main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/vxge/vxge-main.c b/drivers/net/vxge/vxge-main.c
index 1ac9b56..c81a651 100644
--- a/drivers/net/vxge/vxge-main.c
+++ b/drivers/net/vxge/vxge-main.c
@@ -4120,6 +4120,7 @@ int vxge_fw_upgrade(struct vxgedev *vdev, char *fw_name, int override)
"hotplug event.\n");
out:
+ release_firmware(fw);
return ret;
}
--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please.
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] vxge: Remember to release firmware after upgrading firmware {nodisc}
2011-01-13 20:25 [PATCH] vxge: Remember to release firmware after upgrading firmware Jesper Juhl
@ 2011-01-13 20:35 ` Ramkrishna Vepa
2011-01-14 5:50 ` [PATCH] vxge: Remember to release firmware after upgrading firmware David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Ramkrishna Vepa @ 2011-01-13 20:35 UTC (permalink / raw)
To: Jesper Juhl, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Jon Mason, Sivakumar Subramani,
Sreenivasa Honnur
> Regardless of whether the firmware update being performed by
> vxge_fw_upgrade() is a success or not we must still remember to always
> release_firmware() before returning.
>
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
> ---
> vxge-main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/vxge/vxge-main.c b/drivers/net/vxge/vxge-main.c
> index 1ac9b56..c81a651 100644
> --- a/drivers/net/vxge/vxge-main.c
> +++ b/drivers/net/vxge/vxge-main.c
> @@ -4120,6 +4120,7 @@ int vxge_fw_upgrade(struct vxgedev *vdev, char
> *fw_name, int override)
> "hotplug event.\n");
>
> out:
> + release_firmware(fw);
> return ret;
> }
Thanks!
Acked-by: Ram Vepa <ram.vepa@exar.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] vxge: Remember to release firmware after upgrading firmware
2011-01-13 20:25 [PATCH] vxge: Remember to release firmware after upgrading firmware Jesper Juhl
2011-01-13 20:35 ` [PATCH] vxge: Remember to release firmware after upgrading firmware {nodisc} Ramkrishna Vepa
@ 2011-01-14 5:50 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2011-01-14 5:50 UTC (permalink / raw)
To: jj
Cc: netdev, linux-kernel, ramkrishna.vepa, jon.mason,
sivakumar.subramani, sreenivasa.honnur
From: Jesper Juhl <jj@chaosbits.net>
Date: Thu, 13 Jan 2011 21:25:20 +0100 (CET)
> Regardless of whether the firmware update being performed by
> vxge_fw_upgrade() is a success or not we must still remember to always
> release_firmware() before returning.
>
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-01-14 5:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-13 20:25 [PATCH] vxge: Remember to release firmware after upgrading firmware Jesper Juhl
2011-01-13 20:35 ` [PATCH] vxge: Remember to release firmware after upgrading firmware {nodisc} Ramkrishna Vepa
2011-01-14 5:50 ` [PATCH] vxge: Remember to release firmware after upgrading firmware David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).