From: David Miller <davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: figo1802@gmail.com, zealcook@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] ks8695net: Use default implementation of ethtool_ops::get_link
Date: Thu, 13 Jan 2011 21:51:09 -0800 (PST) [thread overview]
Message-ID: <20110113.215109.247138667.davem@davemloft.net> (raw)
In-Reply-To: <1294941171.3946.49.camel@bwh-desktop>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Thu, 13 Jan 2011 17:52:51 +0000
> This is completely untested as I don't have an ARM build environment.
>
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
...
> -/**
> * ks8695_wan_get_pause - Retrieve network pause/flow-control
> advertising
> * @ndev: The device to retrieve settings from
> * @param: The structure to fill out with the information
Line-wrap damage from your mail client.
> @@ -1058,7 +1044,7 @@ static const struct ethtool_ops
> ks8695_wan_ethtool_ops = {
> .get_settings = ks8695_wan_get_settings,
Same here.
I fixed this up and applied your patch.
next prev parent reply other threads:[~2011-01-14 5:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-13 17:50 [PATCH 1/2] ks8695net: Disable non-working ethtool operations Ben Hutchings
2011-01-13 17:52 ` [PATCH 2/2] ks8695net: Use default implementation of ethtool_ops::get_link Ben Hutchings
2011-01-14 5:51 ` David Miller [this message]
2011-01-14 5:50 ` [PATCH 1/2] ks8695net: Disable non-working ethtool operations David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110113.215109.247138667.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=figo1802@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=zealcook@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).