From: David Miller <davem@davemloft.net>
To: daniel@gaisler.com
Cc: netdev@vger.kernel.org, kristoffer@gaisler.com
Subject: Re: [PATCH 04/10] GRETH: added greth_compat_mode module parameter
Date: Thu, 13 Jan 2011 22:14:54 -0800 (PST) [thread overview]
Message-ID: <20110113.221454.149673942.davem@davemloft.net> (raw)
In-Reply-To: <1294907135-24884-4-git-send-email-daniel@gaisler.com>
From: Daniel Hellstrom <daniel@gaisler.com>
Date: Thu, 13 Jan 2011 09:25:29 +0100
> The greth_compat_mode option can be used to set a GRETH GBit capable MAC
> in operate as if the GRETH 10/100 device was found. The GRETH GBit supports
> TCP/UDP checksum offloading, unaligned frame buffers, scatter gather etc.
> Enabling this mode allows the developer to test the GRETH 10/100 device
> without all features mentioned above on a GBit MAC capable of the above.
>
> Signed-off-by: Daniel Hellstrom <daniel@gaisler.com>
No special device specific module parameters please.
What if every single driver author added something like this and they
all named it something different or made it behave in slightly differing
ways?
What kind of user experience would that result in?
It would result in a sucky one, which is why we avoid adding all kinds
of hacky driver specific module options.
Find a generic way to provide this functionality.
next prev parent reply other threads:[~2011-01-14 6:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-13 8:25 [PATCH 01/10] GRETH: added raw AMBA vendor/device number to match against Daniel Hellstrom
2011-01-13 8:25 ` [PATCH 02/10] GRETH: added option to disable a device node from bootloader Daniel Hellstrom
2011-01-14 6:12 ` David Miller
2011-01-14 7:45 ` Daniel Hellstrom
2011-01-13 8:25 ` [PATCH 03/10] GRETH: added no_gbit option Daniel Hellstrom
2011-01-14 6:13 ` David Miller
2011-01-14 7:51 ` Daniel Hellstrom
2011-01-13 8:25 ` [PATCH 04/10] GRETH: added greth_compat_mode module parameter Daniel Hellstrom
2011-01-14 6:14 ` David Miller [this message]
2011-01-14 8:10 ` Daniel Hellstrom
2011-01-13 8:25 ` [PATCH 05/10] GRETH: fix opening/closing Daniel Hellstrom
2011-01-13 8:25 ` [PATCH 06/10] GRETH: GBit transmit descriptor handling optimization Daniel Hellstrom
2011-01-13 8:25 ` [PATCH 07/10] GRETH: fixed skb buffer memory leak on frame errors Daniel Hellstrom
2011-01-13 8:25 ` [PATCH 08/10] GRETH: avoid writing bad speed/duplex when setting transfer mode Daniel Hellstrom
2011-01-13 8:25 ` [PATCH 09/10] GRETH: handle frame error interrupts Daniel Hellstrom
2011-01-13 8:25 ` [PATCH 10/10] GRETH: resolve SMP issues and other problems Daniel Hellstrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110113.221454.149673942.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=daniel@gaisler.com \
--cc=kristoffer@gaisler.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).