From: Sakari Ailus <sakari.ailus@iki.fi>
To: David Miller <davem@davemloft.net>
Cc: joe@perches.com, netdev@vger.kernel.org, chessman@tux.org,
bhutchings@solarflare.com
Subject: Re: [PATCH] tlan: Use pr_fmt, pr_<level> and netdev_<level>, remove changelog
Date: Thu, 13 Jan 2011 08:19:26 +0200 [thread overview]
Message-ID: <20110113061926.GA1900@valkosipuli.localdomain> (raw)
In-Reply-To: <20110109.233950.71582613.davem@davemloft.net>
Hi David,
On Sun, Jan 09, 2011 at 11:39:50PM -0800, David Miller wrote:
> From: Joe Perches <joe@perches.com>
> Date: Thu, 06 Jan 2011 14:48:08 -0800
>
> > Neatening and standardization to the standard logging mechanisms.
> > The changelog isn't useful anymore.
> > Miscellaneous speen/speed typo correction.
> >
> > Signed-off-by: Joe Perches <joe@perches.com>
>
> This patch didn't apply cleanly to the current sources.
>
> And anyways, please resubmit this once 2.6.38-rc1 is out and I
> start taking net-next-2.6 patches again.
Joe's patch applies on top of my patchset "tlan improvements" which contains
a largish code cleanup for the tlan driver. I got comments on that from Ben
Hutchings and haven't sent a new patchset yet.
Instead of fixing partner capability printout I'm removing it since the same
information is available under the mii-tool interface. Ben notified, quite
rightly, that the tlan should be using ethtool interface. That looks like a
topic for another patchset, though.
Regards,
--
Sakari Ailus
sakari dot ailus at iki dot fi
next prev parent reply other threads:[~2011-01-16 0:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-06 18:49 [PATCH 0/3] tlan improvements Sakari Ailus
2011-01-06 18:50 ` [PATCH 1/3] tlan: Code cleanup: checkpatch.pl is relatively happy now Sakari Ailus
2011-01-06 18:50 ` [PATCH 2/3] tlan: Fix partner capability printout Sakari Ailus
2011-01-06 18:50 ` [PATCH 3/3] tlan: add suspend/resume support Sakari Ailus
2011-01-06 19:22 ` [PATCH 2/3] tlan: Fix partner capability printout Ben Hutchings
2011-01-06 19:36 ` Sakari Ailus
2011-01-06 19:44 ` Ben Hutchings
2011-01-06 22:48 ` [PATCH] tlan: Use pr_fmt, pr_<level> and netdev_<level>, remove changelog Joe Perches
2011-01-10 7:39 ` David Miller
2011-01-13 6:19 ` Sakari Ailus [this message]
2011-01-21 20:49 ` Sakari Ailus
2011-01-21 21:09 ` Joe Perches
2011-01-24 21:54 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110113061926.GA1900@valkosipuli.localdomain \
--to=sakari.ailus@iki.fi \
--cc=bhutchings@solarflare.com \
--cc=chessman@tux.org \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox