public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Ben Hutchings" <benh@debian.org>,
	"Michael Tokarev" <mjt@tls.msk.ru>,
	"David Woodhouse" <dwmw2@infradead.org>,
	"Johannes Berg" <johannes.berg@intel.com>,
	"Greg Kroah-Hartman" <gregkh@suse.de>,
	"Francois Romieu" <romieu@fr.zoreil.com>,
	"David Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org, "Jarek Kamiński" <jarek@vilo.eu.org>,
	Hayes <hayeswang@realtek.com>
Subject: Re: [PATCH] r8169: keep firmware in memory.
Date: Fri, 14 Jan 2011 22:44:20 +0100	[thread overview]
Message-ID: <201101142244.21117.rjw@sisk.pl> (raw)
In-Reply-To: <AANLkTinumTQN3F=O_hC=jFTFLKVYyWmJNNvHx2A1jL2p@mail.gmail.com>

On Friday, January 14, 2011, Linus Torvalds wrote:
> On Fri, Jan 14, 2011 at 8:30 AM, Ben Hutchings <benh@debian.org> wrote:
> >
> > This is something I started to implement, but never got finished.  I
> > don't think it can be done without an API change, though, as we need
> > to know when to drop firmware from the cache.  But perhaps this could
> > be done with a hook in the device-driver binding code.
> 
> Or just associate the firmware with a module?
> 
> So if the firmware gets loaded, it stays in memory until the module is unloaded?
> 
> And this all would only be the case if CONFIG_PM is set, so you'd not
> waste memory unnecessarily.

Alternatively, a suspend/hibernate notifier can be used for that I think.

They are called before the freezing and after the thawing of user space, so the
the PM_POST_SUSPEND or PM_POST_RESTORE notification can easily cause the
firmare(s) to be dropped from memory.

Thanks,
Rafael

      reply	other threads:[~2011-01-14 21:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-13 23:07 [PATCH] r8169: keep firmware in memory Francois Romieu
2011-01-14  5:50 ` David Miller
2011-01-14  6:52 ` Michael Tokarev
2011-01-14 16:05   ` Linus Torvalds
2011-01-14 16:30     ` Ben Hutchings
2011-01-14 17:21       ` Linus Torvalds
2011-01-14 21:44         ` Rafael J. Wysocki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201101142244.21117.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=benh@debian.org \
    --cc=davem@davemloft.net \
    --cc=dwmw2@infradead.org \
    --cc=gregkh@suse.de \
    --cc=hayeswang@realtek.com \
    --cc=jarek@vilo.eu.org \
    --cc=johannes.berg@intel.com \
    --cc=mjt@tls.msk.ru \
    --cc=netdev@vger.kernel.org \
    --cc=romieu@fr.zoreil.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox