From: David Miller <davem@davemloft.net>
To: sjurbren@gmail.com
Cc: error27@gmail.com, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] caif: checking the wrong variable
Date: Sat, 15 Jan 2011 21:05:17 -0800 (PST) [thread overview]
Message-ID: <20110115.210517.112602810.davem@davemloft.net> (raw)
In-Reply-To: <AANLkTimyZQ1BEJ=tPK4LrYWhQaGd+xhYUsVEENibEVoU@mail.gmail.com>
From: Sjur Brændeland <sjurbren@gmail.com>
Date: Sat, 15 Jan 2011 15:03:31 +0100
>> In the original code we check if (servl == NULL) twice. The first time
>> should print the message that cfmuxl_remove_uplayer() failed and set
>> "ret" correctly, but instead it just returns success. The second check
>> should be checking the value of "ret" instead of "servl".
>>
>> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> Thank you for spotting and correcting this.
> Looks good to me (reviewed only)
>
> Acked-by: Sjur Braendeland <sjur.brandeland@stericsson.com>
Applied, thanks.
prev parent reply other threads:[~2011-01-16 5:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-15 13:06 [patch] caif: checking the wrong variable Dan Carpenter
2011-01-15 14:03 ` Sjur Brændeland
2011-01-16 5:05 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110115.210517.112602810.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sjurbren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).