From: Dan Carpenter <error27@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: ericvh@gmail.com, sripathik@in.ibm.com, jvrao@linux.vnet.ibm.com,
aneesh.kumar@linux.vnet.ibm.com, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, mohan@in.ibm.com
Subject: Re: [patch] 9p: fix min_t() casting
Date: Sun, 16 Jan 2011 14:45:26 +0300 [thread overview]
Message-ID: <20110116114526.GG2721@bicker> (raw)
In-Reply-To: <20110115.205208.104051310.davem@davemloft.net>
On Sat, Jan 15, 2011 at 08:52:08PM -0800, David Miller wrote:
> From: Dan Carpenter <error27@gmail.com>
> Date: Sat, 15 Jan 2011 23:35:39 +0300
>
> > The intent here was to cap the length to USHRT_MAX, but what the
> > code actually does is it just casts the return from strlen() to
> > unsigned short and truncates the significant bits away.
> >
> > Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> If you want me to apply this, it doesn't apply cleanly to net-2.6
> at all.
Sorry. I screwed up.
This was on top of a patch from M. Mohan Kumar <mohan@in.ibm.com>
that hasn't hit net-2.6 yet. Mohan wasn't included on the CC
list because get_maintainer.pl changed and I didn't notice and
I wasn't careful.
Eric, could Mohan just fix his patch before it gets merged or is it
better to send these as two patches?
regards,
dan carpenter
Ps: Mohon the patch is here:
http://marc.info/?l=linux-netdev&m=129512381528034&w=2
next prev parent reply other threads:[~2011-01-16 11:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-15 20:35 [patch] 9p: fix min_t() casting Dan Carpenter
2011-01-16 4:52 ` David Miller
2011-01-16 11:45 ` Dan Carpenter [this message]
2011-01-16 16:33 ` Eric Van Hensbergen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110116114526.GG2721@bicker \
--to=error27@gmail.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=ericvh@gmail.com \
--cc=jvrao@linux.vnet.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=mohan@in.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=sripathik@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).