From: David Miller <davem@davemloft.net>
To: jesse@nicira.com
Cc: bhutchings@solarflare.com, eric.dumazet@gmail.com,
netdev@vger.kernel.org
Subject: Re: [BUG] bnx2 + vlan + TSO : doesnt work
Date: Mon, 17 Jan 2011 22:09:27 -0800 (PST) [thread overview]
Message-ID: <20110117.220927.189715926.davem@davemloft.net> (raw)
In-Reply-To: <AANLkTincFt4fKLvtity=MgQ2+cuvNFrBHqu3+bMLsypc@mail.gmail.com>
From: Jesse Gross <jesse@nicira.com>
Date: Mon, 17 Jan 2011 16:13:18 -0800
> I think it is better for netif_skb_features() to actually return the
> correct features rather than bypass it here. NETIF_F_HW_VLAN_TX
> doesn't depend on any other offloads, so we can always include it if
> it is in dev->features.
>
> Separately, this means there is a problem with bnx2 because it allows
> vlan insertion to be turned off, which would have the same effect.
> Maybe it is looking directly at skb->protocol or similar for TSO.
Please, someone cons up an acceptable fix fast.
Thanks.
next prev parent reply other threads:[~2011-01-18 6:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-17 23:41 [BUG] bnx2 + vlan + TSO : doesnt work Eric Dumazet
2011-01-17 23:47 ` Ben Hutchings
2011-01-18 0:00 ` Eric Dumazet
2011-01-18 0:09 ` Ben Hutchings
2011-01-18 0:13 ` Jesse Gross
2011-01-18 6:09 ` David Miller [this message]
2011-01-18 6:21 ` Eric Dumazet
2011-01-18 6:32 ` Jesse Gross
2011-01-18 6:38 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110117.220927.189715926.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=eric.dumazet@gmail.com \
--cc=jesse@nicira.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox